-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the 2 gdpr related fields on bids #2549
Conversation
let gdprSignal; | ||
let gdprConsentString; | ||
|
||
if (bid.gdprConsent !== undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about just check if (bid.gdprConsent)
, to avoid "Cannot read property of null"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally to @aodinok suggestion, the gdprConsent
object doesn't exist in the bidRequests
but rather in the bidderRequest
object. This additional variable needs to be added to the buildRequests()
function call.
This would naturally affect the remaining GDPR related code below.
@@ -94,6 +105,8 @@ export const spec = { | |||
referrer, | |||
domain | |||
}, | |||
gdprSignal: gdprSignal, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be just: gdprSignal,
@jsnellbaker any chance you could review the code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @erolosty I'm sorry about the small delay here. I spotted an issue that needs to be addressed otherwise the consent information won't be passed through in your request, please see the in-line comment below.
let gdprSignal; | ||
let gdprConsentString; | ||
|
||
if (bid.gdprConsent !== undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally to @aodinok suggestion, the gdprConsent
object doesn't exist in the bidRequests
but rather in the bidderRequest
object. This additional variable needs to be added to the buildRequests()
function call.
This would naturally affect the remaining GDPR related code below.
Hello @erolosty Did you have the chance to review the feedback? Please let me know if you have any questions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @erolosty wanted to touch-base here again on this PR. Can you please take a look over the feedback and let me know if you have any questions? Thanks. |
Closing per request made in #2733 |
Type of change
Description of change
Adding gdpr support to the quantcast bidder adapter
Be sure to test the integration with your adserver using the Hello World sample page.
contact email of the adapter’s maintainer
dharkin@quantcast.com
official adapter submission
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
gdpr enabled in https://github.com/erolosty/Prebid.js/commit/4196b9f6… prebid.github.io#768
Other information