Allow user to override which gpt slots should be targeted at invocation #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wopps. Not ment to close this as its very valid IMHO and backwards compatible |
mkendall07
reviewed
Jun 1, 2018
src/prebid.js
Outdated
| @@ -156,9 +156,10 @@ $$PREBID_GLOBAL$$.getBidResponsesForAdUnitCode = function (adUnitCode) { | |||
| /** | |||
| * Set query string targeting on one or more GPT ad units. | |||
| * @param {(string|string[])} adUnit a single `adUnit.code` or multiple. | |||
| * @param {function(object)} customSlotMatching gets a GoogleTag slot and returns a filter function. | |||
There was a problem hiding this comment.
Can you update the description and add a usage example here?
ie, this is a a filter function that if passed will override the default matching for a slot.
customSlotMatching(slot) => slot.getAdUnitPath() === 'someIdPassed'
mkendall07
approved these changes
Jun 1, 2018
mkendall07
added
LGTM
needs docs
needs 2nd review
|
Thanks for the feedback, will fix! |
|
Also needs a PR opened here for the new function signature: https://github.com/prebid/prebid.github.io/blob/master/dev-docs/publisher-api-reference-old.md#module_pbjs.setTargetingForGPTAsync Once that's open and linked the |
|
Thanks for the pointer! |
|
@mkendall07 is this ready for merging or did I miss something? |
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
…on (prebid#2562) * Allow user to override which gpt slots should be targeted at invocation time * Added filter example
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
…on (prebid#2562) * Allow user to override which gpt slots should be targeted at invocation time * Added filter example
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
…on (prebid#2562) * Allow user to override which gpt slots should be targeted at invocation time * Added filter example
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…on (prebid#2562) * Allow user to override which gpt slots should be targeted at invocation time * Added filter example
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…on (prebid#2562) * Allow user to override which gpt slots should be targeted at invocation time * Added filter example
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…on (prebid#2562) * Allow user to override which gpt slots should be targeted at invocation time * Added filter example
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We use the following flow:
We start a auction as early as possible. Without knowing where in the feed we're gonna place it. So depending on the outcome of the auction and how long it took we might inject it into a placement defined further down the page in order to now burn views above the fold.
The current semantics of setTargeting requires that we shall know a head of time what gptSlot the targeting should apply for because its looking into the auction object.
But allowing us to pass in an custom slot matching filter we can allow the targeting to explicitly use this slot when setting targeting
We use this in order not to place ads above fold and insert them to a better position instead of everything just being very static.
Other information
Ref #1876 the old attempt, this is way cleaner and just follows along the new 1.x branch
cc: @mkendall07