Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharethrough GDPR updates #2563

Merged
merged 1 commit into from
May 23, 2018

Conversation

chriscpan
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

  • Updates the query passed to our ad server in buildRequests
  • Handles case when ad server returns a null body in getUserSyncs

@mkendall07
Copy link
Member

@chriscpan
LGTM. Please also open a docs PR to add your adapter to the GDPR compliant list. Example here; prebid/prebid.github.io#768

@chriscpan
Copy link
Contributor Author

@mkendall07 Thanks for the review. Made a docs PR to the GDPR compliant list here: prebid/prebid.github.io#782

@jaiminpanchal27 jaiminpanchal27 merged commit 74d04b2 into prebid:master May 23, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@madma madma deleted the cp/gdpr-updates branch November 25, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants