added ccxAdapter

[korys]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• test parameters for validating bids

{
	    code: 'test-banner',
	    mediaTypes: {
		banner: {
		    sizes: [[300, 250]],
		}
	    },
	    bids: [
		{
		    bidder: "ccx",
		    params: {
			placementId: 3286844
		    }
		}
	    ]
	}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer: it@clickonometrics.pl
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[mkendall07]

This pull request introduces 1 alert when merging 4d9452c into ce367d1 - view on lgtm.com

new alerts:

• 1 for Unreachable statement

---

Comment posted by lgtm.com

[jsnellbaker]

Hi @korys Thanks for submitting this new adapter.

I looked over the code and it largely seems good. There were two areas that should be reviewed and they're related to the same topic (see below for the in-line comments).

In addition, I was trying to test the adapter for delivery but I wasn't getting a response from the server. The POST request for both banner and video completed as a 204. I provided a copy of the request objects as they were executed for reference.

Could you take a look? We'd like to ensure a valid bid is returning/rendering for new adapters.

Banner request that was executed during testing:

{"imp":[{"id":"23150d2ee7b8d6","secure":1,"banner":{"format":[{"w":300,"h":250},{"w":300,"h":600}]},"ext":{"pid":3286844}}],"site":{"page":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html"},"device":{"w":1680,"y":1050,"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36"},"id":"641cab37-d175-418a-942c-71ae64a84193","ext":{"ce":1}}

Video request executed during testing:

{"imp":[{"id":"254b2bd70ef68","secure":1,"video":{"w":1920,"h":1080,"protocols":[2,3,5,6],"mimes":["video/mp4","video/x-flv"],"playbackmethod":[1,2,3,4],"skip":0},"ext":{"pid":3287742}}],"site":{"page":"http://ap.localhost:9999/integrationExamples/gpt/video-instream-test.html"},"device":{"w":1680,"y":1050,"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36"},"id":"4635eaf6-a1c6-433d-8997-5821209bd812","ext":{"ce":1}}

[jsnellbaker]

Something to consider, some publishers may not have updated to use mediaTypes in their adUnits code to define sizes and are still using the old adUnits.sizes variable. May wish to add a back-up check to look for this variable as well to help handle those scenarios.

[jsnellbaker]

Another place to consider using adUnits.sizes as a backup.

[korys]

Hi @jsnellbaker,
thank you for so quick review.
I've fixed the issue with empty responses (misconfiguration on our server end).
About adUnits.sizes, we only support Prebid 1.0 and above at the moment and will encourage out publisher to do so.
We'll try to add pre 1.0 support as soon as it's possible.

[jsnellbaker]

@korys Thanks for making the fix on the back-end. I retested both banner and video and everything seemed to be working.