Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RhythmOne Adapter - Added GDPR Support #2576

Merged
merged 3 commits into from
May 22, 2018
Merged

RhythmOne Adapter - Added GDPR Support #2576

merged 3 commits into from
May 22, 2018

Conversation

Rajeshk08
Copy link
Contributor

@Rajeshk08 Rajeshk08 commented May 21, 2018 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ndhimehta ndhimehta assigned snapwich and unassigned ndhimehta May 21, 2018
snapwich
snapwich approved these changes May 21, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

snapwich
snapwich requested changes May 21, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is missing unit test updates around gdpr. Please add.

@Rajeshk08
Copy link
Contributor Author

Updated GDPR unit test case, please check

snapwich
snapwich approved these changes May 22, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 461642f into prebid:master May 22, 2018
Rajeshk08 pushed a commit to Rajeshk08/prebid.github.io that referenced this pull request May 23, 2018
Added gdpr_supported flag for RhythmOne - prebid/Prebid.js#2576
fe60797
@Rajeshk08 Rajeshk08 mentioned this pull request May 23, 2018
Merged
mkendall07 pushed a commit to prebid/prebid.github.io that referenced this pull request May 24, 2018
@Rajeshk08 @mkendall07
Added gdpr_supported flag for RhythmOne - prebid/Prebid.js#2576 (#787)
45662fd
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@Rajeshk08 @dluxemburg
RhythmOne Adapter - Added GDPR Support (prebid#2576)
3e92a87 
* RhythmOne Adapter - Added GDPR Support

* Updated GDPR unit test case

* Adapter version updated
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@Rajeshk08
RhythmOne Adapter - Added GDPR Support (prebid#2576)
dfe25cc 
* RhythmOne Adapter - Added GDPR Support

* Updated GDPR unit test case

* Adapter version updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich approved these changes

Assignees

@snapwich snapwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rajeshk08 @snapwich @ndhimehta