Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonobi Adapter GDPR Support #2582

Merged
merged 3 commits into from
May 23, 2018
Merged

Sonobi Adapter GDPR Support #2582

merged 3 commits into from
May 23, 2018

Conversation

bansawbanchee
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • adding gdpr support

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ndhimehta ndhimehta requested a review from snapwich May 21, 2018 21:12
@ndhimehta ndhimehta assigned snapwich and unassigned ndhimehta May 21, 2018
snapwich
snapwich reviewed May 21, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new third parameter to getUserSyncs that is the gdpr object. Does your pixel need to be updated to take into account gdpr compliance?

@JonGoSonobi
Copy link
Contributor

@snapwich nope, no need to update our pixel to take into account gdpr

@snapwich snapwich merged commit 44305d2 into prebid:master May 23, 2018
@bretg bretg mentioned this pull request Jun 6, 2018
Merged
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@bansawbanchee @dluxemburg
Sonobi Adapter GDPR Support (prebid#2582)
628793c 
* return null from buildRequests if there is no keymakers

* fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port

* Add gdpr support
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@bansawbanchee
Sonobi Adapter GDPR Support (prebid#2582)
fd37d75 
* return null from buildRequests if there is no keymakers

* fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port

* Add gdpr support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich left review comments

Assignees

@snapwich snapwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bansawbanchee @JonGoSonobi @snapwich @ndhimehta