Add GDPR support to GumGum Adapter #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
May 23, 2018
| const bids = []; | ||
| const gdprConsent = Object.assign({ consentString: null, gdprApplies: true }, bidderRequest && bidderRequest.gdprConsent) |
There was a problem hiding this comment.
In case when gdpr module does not exist in the build, this will always send gdprApplies and gdprConsent to your request payload.
https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L77
There was a problem hiding this comment.
It will only send gdprApplies and, at least for us, thats ok. gdprConsent url param is conditional to gdprApplies. Check lines 127-129
data.gdprApplies = gdprConsent.gdprApplies;
if (gdprConsent.gdprApplies) {
data.gdprConsent = gdprConsent.consentString;
}
Do you need us to change this?
jaiminpanchal27
approved these changes
May 24, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adds support for GDPR consent check
PR for new flag in page: prebid/prebid.github.io#785