Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImproveDigital bid adapter GDPR support #2599

Merged
merged 1 commit into from
May 23, 2018

Conversation

jbartek25
Copy link
Contributor

@jbartek25 jbartek25 commented May 23, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Adding support for Prebid ConsentManagement module into ImproveDigital bid adapter + minor internal changes

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Our adapter doesn't need to handle user syncs in any special way for GDPR

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adapter should be updated to use spec.getUserSyncs on the bidderFactory rather than userSync.registerSync directly. I won't block this pull-request so we can get the GDPR stuff through, but this change should be made in the future.

@snapwich snapwich merged commit 41f4c6b into prebid:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants