GDPR use getConsentData CMP call to get consentString #2603
Conversation
modules/consentManagement.js
Outdated
| callIabCMP('getConsentData', function (consentResponse) { | ||
| cmpResponse.getConsentData = consentResponse; | ||
|
|
||
| callIabCMP('getVendorConsents', function (consentResponse) { |
There was a problem hiding this comment.
why are you doing this serially and not in parallel ?
There was a problem hiding this comment.
I wanted to only proceed (ie call cmpSuccess()) when I had the responses from both callbacks. This is to collect the results from both and store them into one object to process later. I'm not sure how to best organize having two parallel callbacks meld their results together.
There was a problem hiding this comment.
I can chat about this with you if you're interested.
It's much more straightforward with Promise-based APIs... but it can still be done with callback-based ones.
There was a problem hiding this comment.
yeah I think parallel would be ideal, especially if these are making ajax requests. If they're not, it probably doesn't matter.
There was a problem hiding this comment.
I don't think these are making ajax requests - so it probably doesn't matter so much.
|
I have updated the logic to have the CMP calls execute in a parallel instead of serial as well as resolve the current conflicts with master. Please take another look and let me know of any additional feedback/suggestions. Thanks. |
|
Thanks for the approvals - merging in now. |
* use getConsentData cmp to get consent info * add changes for safeframe and iframe workflows * update logic to execute CMP calls in parallel
* use getConsentData cmp to get consent info * add changes for safeframe and iframe workflows * update logic to execute CMP calls in parallel
Type of change
Description of change
Previously the consentManagement module was using the CMP function
getVendorConsentsto obtain all aspects of the user's consent information. It was pointed out in #2591 that this function is not the ideal one to use to obtain the user's consent information (specifically the encoded string).This PR updates the logic of the module to use the
getConsentDataCMP function to grab theconsentStringandgdprAppliesand then executes thegetVendorConsentsCMP function to grab the unparsed vendor consent information (to maintain backwards compatibility for that variable we offer to adapters).