Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encodeURIComponent to referer url (getTopWindowUrl) #2609

Merged
merged 28 commits into from
May 30, 2018
Merged

Add encodeURIComponent to referer url (getTopWindowUrl) #2609

merged 28 commits into from
May 30, 2018

Conversation

gammassp
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add encodeURIComponent to referer url (getTopWindowUrl)

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@gammassp
commit gamma adapter
1139ef1
@gammassp
Fixed The Travis CI build failed
f0346d6
@gammassp
fix interpretResponse return empty when server response empty
44cc909
@gammassp
removed mediaType
1f76f1d 
removed mediaType in bid 
and return vastXml property if video request
@gammassp
fixed Travis CI build
895d71e
@gammassp
Travis CI build
8e3c38a
@gammassp
add gamma spec
e83dd68
@gammassp
fixed Travis CI build
ffbfddb
@gammassp
fix spec
57d241c
@gammassp
fix spec
ce3f6ea
@gammassp
Add files via upload
f63f0ec
@gammassp
Add files via upload
489a8f1
@gammassp
fix spec
718a4e7
@gammassp
fix Travis CI build
efba42f
@gammassp
move to module
94e1f10
@gammassp
remove gaxDomain param and move to adapter
25e2520
@gammassp
remove check isBidRequestValid for gaxDomain
b9889ad
@gammassp
remove gaxDomain param
eca96a9
@gammassp
remove gaxDomain param
f5cf69e
@gammassp
remove gaxDomain param
a7bbbb2
@gammassp
Delete gammaBidAdapter_spec.js
81ed069
@gammassp
add usersync endpoid
bb4169c
@gammassp
Merge branch 'master' into master
29c0732
@gammassp
add usersync
6ca18f4
@gammassp
add vastUrl
1548a0c
@gammassp
add supportedMediaTypes to bidder spec
7e5f905
@gammassp
add Test Parameters: For Video
3163130
@gammassp
Add encodeURIComponent for referer url
146f7e2
@ndhimehta ndhimehta removed their assignment May 29, 2018
idettman
idettman approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returns bids with test data, LGTM

@idettman idettman merged commit 897155a into prebid:master May 30, 2018
Pupis pushed a commit to adform/Prebid.js that referenced this pull request Jun 7, 2018
@gammassp @Pupis
Add encodeURIComponent to referer url (getTopWindowUrl) (prebid#2609)
31d6b69 
* commit gamma adapter

* Fixed The Travis CI build failed

* fix interpretResponse return empty when server response empty

* removed mediaType

removed mediaType in bid 
and return vastXml property if video request

* fixed Travis CI build

* Travis CI build

* add gamma spec

* fixed Travis CI build

* fix spec

* fix spec

* Add files via upload

* Add files via upload

* fix spec

* fix Travis CI build

* move to module

* remove gaxDomain param and move to adapter

* remove check isBidRequestValid for gaxDomain

* remove gaxDomain param

* remove gaxDomain param

* remove gaxDomain param

* Delete gammaBidAdapter_spec.js

* add usersync endpoid

* add usersync

* add vastUrl

* add supportedMediaTypes to bidder spec

* add Test Parameters: For Video

* Add encodeURIComponent for referer url
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@gammassp @dluxemburg
Add encodeURIComponent to referer url (getTopWindowUrl) (prebid#2609)
524b5c5 
* commit gamma adapter

* Fixed The Travis CI build failed

* fix interpretResponse return empty when server response empty

* removed mediaType

removed mediaType in bid 
and return vastXml property if video request

* fixed Travis CI build

* Travis CI build

* add gamma spec

* fixed Travis CI build

* fix spec

* fix spec

* Add files via upload

* Add files via upload

* fix spec

* fix Travis CI build

* move to module

* remove gaxDomain param and move to adapter

* remove check isBidRequestValid for gaxDomain

* remove gaxDomain param

* remove gaxDomain param

* remove gaxDomain param

* Delete gammaBidAdapter_spec.js

* add usersync endpoid

* add usersync

* add vastUrl

* add supportedMediaTypes to bidder spec

* add Test Parameters: For Video

* Add encodeURIComponent for referer url
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@gammassp
Add encodeURIComponent to referer url (getTopWindowUrl) (prebid#2609)
4c13380 
* commit gamma adapter

* Fixed The Travis CI build failed

* fix interpretResponse return empty when server response empty

* removed mediaType

removed mediaType in bid 
and return vastXml property if video request

* fixed Travis CI build

* Travis CI build

* add gamma spec

* fixed Travis CI build

* fix spec

* fix spec

* Add files via upload

* Add files via upload

* fix spec

* fix Travis CI build

* move to module

* remove gaxDomain param and move to adapter

* remove check isBidRequestValid for gaxDomain

* remove gaxDomain param

* remove gaxDomain param

* remove gaxDomain param

* Delete gammaBidAdapter_spec.js

* add usersync endpoid

* add usersync

* add vastUrl

* add supportedMediaTypes to bidder spec

* add Test Parameters: For Video

* Add encodeURIComponent for referer url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idettman idettman idettman approved these changes

Assignees

@idettman idettman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gammassp @idettman @ndhimehta