Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GDPR support for Quantum Adapter #2621

Merged
merged 29 commits into from
May 31, 2018
Merged

Conversation

sami-elasticad
Copy link
Contributor

  • Feature

Description of change

GDPR support for Quantum Adapter

  • contact email of the adapter’s maintainer
  • official adapter submission

@ndhimehta ndhimehta assigned snapwich and unassigned ndhimehta May 29, 2018
@snapwich snapwich self-requested a review May 29, 2018 20:14
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be updating the package-lock.json file. Also, one of your tests should reflect the changes to the bidder request that now includes GDPR data.

@sami-elasticad
Copy link
Contributor Author

Please review changes. Thank you.

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 0519902 into prebid:master May 31, 2018
Pupis pushed a commit to adform/Prebid.js that referenced this pull request Jun 7, 2018
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants