Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ix bid adapter, default to assuming media type is banner #2632

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

dumbmatter
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

As described in #2574, this code:

if (utils.deepAccess(validBidRequest, 'mediaTypes.banner') ||
        validBidRequest.mediaType === 'banner') {
        bannerImp = bidToBannerImp(validBidRequest);
        bannerImps.push(bannerImp);
}

assumes that mediaType or mediaTypes is set. According to http://prebid.org/dev-docs/publisher-api-reference.html specifying the media type is optional and it should default to assuming it's a banner.

This PR makes it assume the media type is banner if it's not set.

Other information

#2574

@jaiminpanchal27 jaiminpanchal27 merged commit 6be4980 into prebid:master Jun 8, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants