-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rtbhouse adapter GDPR integration. #2641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Marcian123 Please see the comment below in regards to the code changes in the adapter file.
Additionally, would you be able to open a docs PR in the docs repo and make an update in your bidders page to add the following variable?
gdpr_supported: true
This can go directly below the variable for your 1.0 compliance. This will allow your adapter to appear in a table that shows GDPR compliant adapters. Thanks.
modules/rtbhouseBidAdapter.js
Outdated
test: validBidRequests[0].params.test || 0 | ||
test: validBidRequests[0].params.test || 0, | ||
}; | ||
if (validBidRequests[0].gdprConsent && validBidRequests[0].gdprConsent.gdprApplies) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gdprConsent
doesn't exist under the validBidRequests
parameter. It exists under the 2nd parameter for the buildrequests
function (typically called bidderRequest
).
You'll need to add-in this extra parameter and then use that to read the gdprConsent
data.
Fixed |
* Add files via upload * Delete rtbhouseBidAdapter_spec.js * Delete rtbhouseBidAdapter.js * Added GDPR integration to RTBhouse adapter * Update rtbhouseBidAdapter_spec.js * Added GDPR consent as second build attribute. * Added gdpr as second attribute in test.
* Add files via upload * Delete rtbhouseBidAdapter_spec.js * Delete rtbhouseBidAdapter.js * Added GDPR integration to RTBhouse adapter * Update rtbhouseBidAdapter_spec.js * Added GDPR consent as second build attribute. * Added gdpr as second attribute in test.
* Add files via upload * Delete rtbhouseBidAdapter_spec.js * Delete rtbhouseBidAdapter.js * Added GDPR integration to RTBhouse adapter * Update rtbhouseBidAdapter_spec.js * Added GDPR consent as second build attribute. * Added gdpr as second attribute in test.
Type of change
Description of change
Added GDPR integration to rtbhouse adapter.
Added tests to this feature.
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information