Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arteebee adapter GDPR integration #2643

Merged
merged 17 commits into from
May 30, 2018
Merged

Arteebee adapter GDPR integration #2643

merged 17 commits into from
May 30, 2018

Conversation

jeffyecn
Copy link
Contributor

Type of change

  • Feature

Description of change

Add support for GDPR via consent manager module and related test case

  • contact email of the adapter’s maintainer: jeffyecn@gmail.com
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jeffyecn I was testing out the adapter using the test param information in the .md file, and I was seeing a 400 Bad Request error on the server request.

Below is a copy of the request object that returned the error:

{"imp":[{"id":"2b4b011b89aad","banner":{"format":[{"w":300,"h":250},{"w":300,"h":600}]}}],"site":{"id":"prebidtest","page":"http://ap.localhost:9999/integrationExamples/gpt/gdpr_hello_world.html?pbjs_debug=true","ref":"http://ap.localhost:9999/integrationExamples/gpt/gdpr_hello_world.html?pbjs_debug=true","publisher":{"id":"prebidtest","domain":"ap.localhost:9999"}},"device":{"ua":"caller","ip":"caller","js":1},"at":1,"tmax":3000,"regs":{"ext":{"gdpr":1}},"user":{"ext":{"consent":"BOOUW7QOOUW7QABABAENAd-AAAAVl7_______9____7_9uz_Gv_r_ff_3nW0739P1A_r_Oz_qG_6xzVo4_FpQAQ"}},"test":1}

Could you take a look to see why the error is happening? Is there an updated set of test params to use?

@jeffyecn
Copy link
Contributor Author

Hi, @jsnellbaker Code has been updated to fix this issue.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update; I checked it again and the bids are coming back successfully and the consent information is being passed into the request properly.

@jsnellbaker jsnellbaker merged commit 4bde2a1 into prebid:master May 30, 2018
Pupis pushed a commit to adform/Prebid.js that referenced this pull request Jun 7, 2018
* add arteebee adapter

* set log

* basic structure

* basic structure

* send caller as placeholder for ip and user agent

* send caller as placeholder for ip and user agent

* send caller as placeholder for ip and user agent

* first version of adapter

* add unit testing for arteebee bid adapter

* fix indent

* fix lint complain

* Add consent manager support

* fix requestId missing
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* add arteebee adapter

* set log

* basic structure

* basic structure

* send caller as placeholder for ip and user agent

* send caller as placeholder for ip and user agent

* send caller as placeholder for ip and user agent

* first version of adapter

* add unit testing for arteebee bid adapter

* fix indent

* fix lint complain

* Add consent manager support

* fix requestId missing
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* add arteebee adapter

* set log

* basic structure

* basic structure

* send caller as placeholder for ip and user agent

* send caller as placeholder for ip and user agent

* send caller as placeholder for ip and user agent

* first version of adapter

* add unit testing for arteebee bid adapter

* fix indent

* fix lint complain

* Add consent manager support

* fix requestId missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants