Update bid pool logic to use highest cpm bid #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To note - believe should also fix #2539 |
mkendall07
approved these changes
May 30, 2018
src/targeting.js
Outdated
| ; | ||
|
|
||
| return getHighestCpmBidsFromBidPool(bidsReceived); |
| // bucket by adUnitcode | ||
| let buckets = groupBy(bidsReceived, 'adUnitCode'); | ||
| // filter top bid for each bucket by bidder | ||
| Object.keys(buckets).forEach(bucketKey => { |
There was a problem hiding this comment.
bucketKey => adUnitCode
(I know you just moved it but might as well fix it now)
mkendall07
approved these changes
May 30, 2018
mkendall07
approved these changes
May 30, 2018
Pupis
pushed a commit
to adform/Prebid.js
that referenced
this pull request
Jun 7, 2018
* update bid pool logic to use highest cpm bid * updates to cover prebid#2539 * typo in property name
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* update bid pool logic to use highest cpm bid * updates to cover prebid#2539 * typo in property name
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* update bid pool logic to use highest cpm bid * updates to cover prebid#2539 * typo in property name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2448