Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audience Network: add debug params to bid requests #2657

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

lovell
Copy link
Contributor

@lovell lovell commented May 30, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Hello, this PR adds two new parameters to the bid request to help publishers when debugging.

The platform value is specific to Prebid and will not change. The adapterver value will be manually updated with any future changes to this adapter.

The now-deprecated pbv parameter, previously used for this purpose, is replaced with platver.

This work was commissioned and paid for by Facebook.

@snapwich
Copy link
Collaborator

snapwich commented Jun 7, 2018

@lovell it looks good to me, although it looks like you have some conflicts that need to be resolved.

@lovell lovell force-pushed the audience-network-debug-params branch from 2021595 to b2e8f60 Compare June 9, 2018 10:16
@lovell
Copy link
Contributor Author

lovell commented Jun 9, 2018

Thanks, have rebased.

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snapwich had already verbally approved.

@harpere harpere added the LGTM label Jun 20, 2018
@harpere harpere merged commit 3418665 into prebid:master Jun 20, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants