-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getTopWindowUrl #2673
Fix getTopWindowUrl #2673
Conversation
getTopWindowUrl error, it should be exports.function not this.function
Fix to pass FB test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand these changes. Is it just a FB test that needs this? or is there a real production problem? And under what circumstances does exports.getTopWindowLocation()
work, but not this..getTopWindowLocation()
?
As discussed I have edited to the correct behaviour and edit some change on Karma test for AudienceNetwork adapter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
getTopWindowUrl error, it should be exports.function not this.function
FB adapter is relying on this for getting the top location and for Postbid in Safeframe the referer is not passed. exports.getTopWindowLocation() should be used if this.getTopWindowLocation is not defined.
The FB JS test is made so pagueUrl must be void instead of returning the page (localhost for) or url format. That is why I was forced to do if (href.search(‘localhost/?‘) > 0) { href = ‘’; }
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information