Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Prebid Analytics by Roxot #2688

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Refactoring Prebid Analytics by Roxot #2688

merged 2 commits into from
Jun 7, 2018

Conversation

mikhail-roxot
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Big refactoring Analytics Adapter by Roxot

  • contact email of the adapter’s maintainer: mikhail@roxot.com
  • official adapter submission

@mkendall07
Copy link
Member

This pull request fixes 1 alert when merging 7a6fc76 into ee4074e - view on LGTM.com

fixed alerts:

  • 1 for Superfluous trailing arguments

Comment posted by LGTM.com

@ndhimehta ndhimehta assigned snapwich and unassigned ndhimehta Jun 7, 2018
@snapwich snapwich self-requested a review June 7, 2018 17:32
snapwich
snapwich approved these changes Jun 7, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit to remove a bunch of the adaptermanager stuff (it's unnecessary and clutters up the tests). Other than that, LGTM.

@snapwich snapwich force-pushed the roxot/refactoring-analytics-adapter branch from c5675a2 to df66ba1 Compare June 7, 2018 17:35
@mkendall07
Copy link
Member

This pull request fixes 1 alert when merging df66ba1 into 1646c0b - view on LGTM.com

fixed alerts:

  • 1 for Superfluous trailing arguments

Comment posted by LGTM.com

@snapwich snapwich merged commit 322ebfe into prebid:master Jun 7, 2018
@mikhail-roxot mikhail-roxot deleted the roxot/refactoring-analytics-adapter branch June 8, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich approved these changes

Assignees

@snapwich snapwich

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikhail-roxot @mkendall07 @snapwich @ndhimehta @jsnellbaker