Fyber Bid Adapter #2709
Merged
Fyber Bid Adapter #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-chowla
requested changes
Jun 12, 2018
There was a problem hiding this comment.
Please review:
http://prebid.org/dev-docs/bidder-adaptor.html
modules/fyberBidAdapter.js
Outdated
| } | ||
|
|
||
| if (typeof $$PREBID_GLOBAL$$ !== 'undefined') { | ||
| toQueryString.bco = $$PREBID_GLOBAL$$.cbTimeout || $$PREBID_GLOBAL$$.bidderTimeout; |
There was a problem hiding this comment.
Adapters are not permitted to reference
modules/fyberBidAdapter.js
Outdated
| * @param urls: Array<String> | ||
| */ | ||
| fire(urls) { | ||
| urls.forEach(url => url && ((new Image(1, 1)).src = encodeURI(url))); |
There was a problem hiding this comment.
Adapters are not permitted to create their own tracking pixels. If you want to fire a pixel, return it from getUserSyncs()
|
@mike-chowla, thanks. |
uriw-fyber
commented
Jun 17, 2018
There was a problem hiding this comment.
@mike-chowla, we've made changes based on your review. Is there something more we need to do from our side to proceed with the pull request?
mike-chowla
approved these changes
Jun 18, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Fyber Bid Adapter * Jenkins build file * Updates based on PR - prebid#2709 * Removing test Jenkinsfile
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* Fyber Bid Adapter * Jenkins build file * Updates based on PR - prebid#2709 * Removing test Jenkinsfile
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* Fyber Bid Adapter * Jenkins build file * Updates based on PR - prebid#2709 * Removing test Jenkinsfile
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Fyber Bid Adapter * Jenkins build file * Updates based on PR - prebid#2709 * Removing test Jenkinsfile
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Fyber Bid Adapter * Jenkins build file * Updates based on PR - prebid#2709 * Removing test Jenkinsfile
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Fyber Bid Adapter * Jenkins build file * Updates based on PR - prebid#2709 * Removing test Jenkinsfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New Bid Adapter for Fyber (https://www.fyber.com)
Be sure to test the integration with your adserver using the Hello World sample page.
uri@inner-active.com
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Link to documentation:
prebid/prebid.github.io#830