Integration of Realvu analytics in Somo adapter #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
requested changes
Jun 15, 2018
modules/somoaudienceBidAdapter.js
Outdated
| @@ -1,5 +1,6 @@ | |||
| import {getTopWindowReferrer, getTopWindowLocation} from 'src/utils'; | |||
| import { registerBidder } from 'src/adapters/bidderFactory'; | |||
| const realvuAnalyticsAdapter = require('modules/realvuAnalyticsAdapter.js'); | |||
There was a problem hiding this comment.
You can't pull in other modules from an adapter. There's no build-time way to do this, and run-time loading of code isn't allowed.
It appears you're trying to link Somo and RealVu... there's not a precedence for this. Please explain the background?
…d checking for and using the variables directly
|
@bretg Sorry for the confusion. Somoaudience entered into an agreement with RealVu and would like to have their analytics adapter included for data collection on viewability and to also send some additional information to our bidder relating as such. I have push some changes to not required the adapter but instead look to see if the variables are initialized before doing any realvu related operations. Thank You |
bretg
added
needs 2nd review
harpere
added
LGTM
and removed
needs 2nd review
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Integration of Realvu analytics in Somo adapter * Bug Fixes * Reworked adapter to not require or include the realvu adapter. instead checking for and using the variables directly
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* Integration of Realvu analytics in Somo adapter * Bug Fixes * Reworked adapter to not require or include the realvu adapter. instead checking for and using the variables directly
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* Integration of Realvu analytics in Somo adapter * Bug Fixes * Reworked adapter to not require or include the realvu adapter. instead checking for and using the variables directly
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Integration of Realvu analytics in Somo adapter * Bug Fixes * Reworked adapter to not require or include the realvu adapter. instead checking for and using the variables directly
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Integration of Realvu analytics in Somo adapter * Bug Fixes * Reworked adapter to not require or include the realvu adapter. instead checking for and using the variables directly
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Integration of Realvu analytics in Somo adapter * Bug Fixes * Reworked adapter to not require or include the realvu adapter. instead checking for and using the variables directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Integrating the RealVu Analytics Adapter into the Somo Audience Bid Adapter.