Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IX Adapter: Backward compatible with legacy config & reduced TTL #2744

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

ix-prebid-support
Copy link
Contributor

@ix-prebid-support ix-prebid-support commented Jun 20, 2018

Backward compatible update & reduced TTL

Type of change

  • Feature
  • Refactoring
  • Bugfix

Description of change

@ix-prebid-support ix-prebid-support changed the title Backward compatible update & reduced TTL IX Adapter: Backward compatible update & reduced TTL Jun 20, 2018
@ix-prebid-support ix-prebid-support changed the title IX Adapter: Backward compatible update & reduced TTL IX Adapter: Backward compatible with legacy config & reduced TTL Jun 20, 2018
@ix-prebid-support
Copy link
Contributor Author

@harpere @idettman
Any update on the above request that can be shared with us?

@dmitriyshashkin
Copy link
Contributor

Ran a test in prod environment and I can confirm that this change does fix the issue with the discrepancy. Really hope that it'll be included in a release soon

@mike-chowla mike-chowla self-assigned this Jul 3, 2018
@mike-chowla mike-chowla self-requested a review July 3, 2018 20:24
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 204daf8 into prebid:master Jul 3, 2018
@mike-chowla
Copy link
Contributor

@ix-prebid-support Please file a corresponding PR to cleanup your bidder docs on Prebid.org as well. They too are showing a bunch of html formatting

@ix-prebid-support
Copy link
Contributor Author

@mike-chowla

Thanks for highlighting it. The PR prebid/prebid.github.io#868 was created to address this.

dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants