Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sending information about prebid and adapter versions in request #2753

Merged
merged 2 commits into from
Jun 22, 2018
Merged

sending information about prebid and adapter versions in request #2753

merged 2 commits into from
Jun 22, 2018

Conversation

nwlosinski
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Sending information about prebid and adapter versions in request.

Other information

@nwlosinski

harpere
harpere requested changes Jun 21, 2018
View reviewed changes
Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about adding these new params to your tests?

@harpere harpere self-assigned this Jun 21, 2018
@nwlosinski
Copy link
Contributor Author

Oh yes. I forgot about that.
Thanks @harpere

@harpere harpere merged commit afd974b into prebid:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harpere harpere harpere approved these changes

Assignees

@harpere harpere

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwlosinski @harpere