Add gdpr and targeting support for Yieldlab adapter #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for optional key-value targeting. As the request to Yieldlab is joint, we expect the targeting params to be present for only one of the adUnits or to be the same for every adUnit.
Support for the Prebid.js consent management module. Passing "consent" and "gdpr" (default: true) parameters if present.
harpere
approved these changes
Jun 22, 2018
| }) | ||
|
|
||
| if (bidderRequest && bidderRequest.gdprConsent) { | ||
| query.consent = bidderRequest.gdprConsent.consentString | ||
| query.gdpr = (typeof bidderRequest.gdprConsent.gdprApplies === 'boolean') ? bidderRequest.gdprConsent.gdprApplies : true |
There was a problem hiding this comment.
just verifying that you want to default gdprApplies to true
There was a problem hiding this comment.
Yes, gdprApplies=true should be the default. Thanks for making sure!
harpere
approved these changes
Jun 22, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Add targeting support Support for optional key-value targeting. As the request to Yieldlab is joint, we expect the targeting params to be present for only one of the adUnits or to be the same for every adUnit. * Add GDPR support Support for the Prebid.js consent management module. Passing "consent" and "gdpr" (default: true) parameters if present.
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* Add targeting support Support for optional key-value targeting. As the request to Yieldlab is joint, we expect the targeting params to be present for only one of the adUnits or to be the same for every adUnit. * Add GDPR support Support for the Prebid.js consent management module. Passing "consent" and "gdpr" (default: true) parameters if present.
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* Add targeting support Support for optional key-value targeting. As the request to Yieldlab is joint, we expect the targeting params to be present for only one of the adUnits or to be the same for every adUnit. * Add GDPR support Support for the Prebid.js consent management module. Passing "consent" and "gdpr" (default: true) parameters if present.
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Add targeting support Support for optional key-value targeting. As the request to Yieldlab is joint, we expect the targeting params to be present for only one of the adUnits or to be the same for every adUnit. * Add GDPR support Support for the Prebid.js consent management module. Passing "consent" and "gdpr" (default: true) parameters if present.
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Add targeting support Support for optional key-value targeting. As the request to Yieldlab is joint, we expect the targeting params to be present for only one of the adUnits or to be the same for every adUnit. * Add GDPR support Support for the Prebid.js consent management module. Passing "consent" and "gdpr" (default: true) parameters if present.
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Add targeting support Support for optional key-value targeting. As the request to Yieldlab is joint, we expect the targeting params to be present for only one of the adUnits or to be the same for every adUnit. * Add GDPR support Support for the Prebid.js consent management module. Passing "consent" and "gdpr" (default: true) parameters if present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Add gdpr support and key-value targeting to the Yieldlab bidder prebid.github.io#851
Description of change
solutions@yieldlab.de