Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass timedOut as argument to bidsBackHandler function #2772

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Pass timedOut as argument to bidsBackHandler function #2772

merged 1 commit into from
Jul 9, 2018

Conversation

seankarson
Copy link
Contributor

@seankarson seankarson commented Jun 26, 2018 •
edited
Loading

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

  • bidsBackHandler can be called in two main cases:
  1. if the all the bids come back before the timeout is hit
  2. if the timeout is hit

cc/ @nanek

@seankarson seankarson mentioned this pull request Jun 26, 2018
Merged
snapwich
snapwich approved these changes Jun 28, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@snapwich snapwich added the needs 2nd review Core module updates require two approvals from the core team label Jun 28, 2018
@jaiminpanchal27 jaiminpanchal27 merged commit b15e7bb into prebid:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich approved these changes

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
needs review needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seankarson @snapwich @jaiminpanchal27 @jsnellbaker