PBS Adapter: call done when ajax request fails #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbemiller
approved these changes
Jun 29, 2018
modules/prebidServerBidAdapter.js
Outdated
| response => handleResponse(response, requestedBidders, bidRequests, addBidResponse, done), | ||
| { | ||
| success: response => handleResponse(response, requestedBidders, bidRequests, addBidResponse, done), | ||
| error: () => { done(); } |
There was a problem hiding this comment.
Should this error be logged somewhere, so it shows up in debug mode?
If not: error: done should work here. No need to wrap the function in another function.
mike-chowla
added
the
needs 2nd review
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* call done when ajax request fails * no need to wrap function here
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* call done when ajax request fails * no need to wrap function here
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* call done when ajax request fails * no need to wrap function here
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* call done when ajax request fails * no need to wrap function here
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* call done when ajax request fails * no need to wrap function here
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* call done when ajax request fails * no need to wrap function here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
PBS adapter was not calling done when ajax requests fails. done not getting called means auction will not close if all other bidders are back before timeout.