Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sovrn: Send IV as query param #2797

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Sovrn: Send IV as query param #2797

merged 1 commit into from
Jul 5, 2018

Conversation

aprakash-sovrn
Copy link
Contributor

@aprakash-sovrn aprakash-sovrn commented Jun 29, 2018 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

We need to send a sovrn custom parameter as a query parameter instead of in the request body

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@mike-chowla mike-chowla self-assigned this Jul 3, 2018
@mike-chowla mike-chowla changed the title Send IV as query param Sovrn: Send IV as query param Jul 5, 2018
@mike-chowla mike-chowla self-requested a review July 5, 2018 23:39
mike-chowla
mike-chowla approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 5b0a5b7 into prebid:master Jul 5, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@aprakash-sovrn @dluxemburg
Send IV as query param (prebid#2797)
d62a295
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
@aprakash-sovrn @florevallatmrf
Send IV as query param (prebid#2797)
a02aa38
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
@aprakash-sovrn @StefanWallin
Send IV as query param (prebid#2797)
89baa91
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@aprakash-sovrn
Send IV as query param (prebid#2797)
9dece95
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
@aprakash-sovrn @AlessandroDG
Send IV as query param (prebid#2797)
01f627e
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
@aprakash-sovrn @AlessandroDG
Send IV as query param (prebid#2797)
26cc940
@s-nikulin-lineate s-nikulin-lineate deleted the sovrn_adapter_custom_param_update branch June 20, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-chowla mike-chowla mike-chowla approved these changes

Assignees

@mike-chowla mike-chowla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aprakash-sovrn @mike-chowla