Add bid adapter for Ad Up Technology

[SteffenAnders]

Type of change

• New bidder adapter

Description of change

Add bid adapter for Ad Up Technology

Test parameter

{
  bidder: 'aduptech',
  params: {
    publisher: 'prebid',
    placement: '12345'
  }
}

Maintainer

• steffen.anders@adup-tech.com
• official adapter submission

Documentation

• PR on the docs repo at https://github.com/prebid/prebid.github.io is HERE

[jsnellbaker]

Hi @SteffenAnders,

Thanks for submitting this adapter. There are two points I saw that need to be reviewed further:

• When I was testing with the test param information on the hello_world.html test page, I was receiving an empty response from the server. Could you take a look to see why this may be the case? For new adapters, we want to see an ad deliver during the initial review to ensure everything seems to be working.
• I noticed in the docs PR you had gdpr_supported: true, but I don't see the normal corresponding code in your buidRequests method that reads the gdpr information prebid collected from the CMP. Could you confirm if the adapter is meant to be GDPR compliant?

For reference to the delivery point, below is a copy of the request object as it was executed:

{"pageUrl":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","referrer":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","bidId":"23a185fb3ec7cb","auctionId":"494f7e4c-b4b3-4644-a287-68527ab924fb","transactionId":"dcf59036-0a18-4cbb-915d-e3164c5071d4","adUnitCode":"div-gpt-ad-1460505748561-0","sizes":[[300,250],[300,600]],"params":{"publisher":"prebid","placement":"12345"}}

[SteffenAnders]

@jsnellbaker @mike-chowla

Thanks for reviewing.

When I was testing with the test param information on the hello_world.html test page, I was receiving an empty response from the server. Could you take a look to see why this may be the case? For new adapters, we want to see an ad deliver during the initial review to ensure everything seems to be working.

Our bidder returns an empty object as fallback e.g. if the request runs into an internal timeout. In the normal case a valid bid response should be returned when using the test publisher "prebid". In my local tests with the hello_world.html ~ 9 of 10 bid requests got a valid response.
Suggestion: If you add the debug parameter (debug: true) to the params object, you will see more information in our response.

I noticed in the docs PR you had gdpr_supported: true, but I don't see the normal corresponding code in your buidRequests method that reads the gdpr information prebid collected from the CMP. Could you confirm if the adapter is meant to be GDPR compliant?

You were right. Now we pass the prebid GDRP information to our bidder via buildRequests.

I have also rebased this branch to current master, maybe that solved some problems.

[jsnellbaker]

Hi @SteffenAnders,
Thanks for the follow-up and making the changes.

I confirmed the GDPR code is working within the adapter. However I'm still seeing response issue.

Below is a copy of the response with the debug param included:

{"debug_time":81,"debug_reject":"timeout","debug_keywords":"[]"}

[SteffenAnders]

@jsnellbaker

We have increased the timeouts of our bidder and fixed some problems with the HTTPS certificate.
Can you please try it again?

[jsnellbaker]

@SteffenAnders Thanks for making the additional changes, it seems to be working now.