1206 eslint repair camel case #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jrosendahl Thanks for putting together all these changes. The changes here look good. However there was another bidder recently merged into master that appears to fail the new lint checks. Could you rebase off of master to incorporate this bidder ( Below is a copy of the lint errors for reference: We should be good to merge at that point. |
added 2 commits
August 2, 2018 13:26
|
Should be updated, let me know if you need anything else. |
jsnellbaker
approved these changes
Aug 3, 2018
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* Camel Case issues addresed * after merge cleanup * updated between adapter
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* Camel Case issues addresed * after merge cleanup * updated between adapter
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Camel Case issues addresed * after merge cleanup * updated between adapter
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Camel Case issues addresed * after merge cleanup * updated between adapter
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Camel Case issues addresed * after merge cleanup * updated between adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Enabled camelCase checking in .eslintrc
Made necessary code changes for linting to pass
Added one eslint ignore line for potential global variable
Other information
Addresses Issue 1206