PROPS IPAX - GIANTS Adapter #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newline end file
snapwich
requested changes
Aug 6, 2018
modules/giantsBidAdapter.js
Outdated
|
|
||
| export const spec = { | ||
| code: BIDDER_CODE, | ||
| aliases: ['giants'], |
There was a problem hiding this comment.
This is not needed. The adapter is already called the giants adapter, so this alias is a duplicate.
|
We removed alias and added GDPR. |
|
Please let me know what I need to do next so my adapter can be updated to the adapter list on prebid.org. |
|
to get on the download page you need to submit a bidders md file as outlined here: https://github.com/prebid/prebid.github.io#the-downloads-page |
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* add giants bidder * add giants bidder spec * newline end file newline end file * add GDPR Module
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* add giants bidder * add giants bidder spec * newline end file newline end file * add GDPR Module
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* add giants bidder * add giants bidder spec * newline end file newline end file * add GDPR Module
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* add giants bidder * add giants bidder spec * newline end file newline end file * add GDPR Module
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* add giants bidder * add giants bidder spec * newline end file newline end file * add GDPR Module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.