Media.net Adapter Improvements #2954
Conversation
vedantseta
force-pushed
the
pr-timeout-bidwon-event
branch
from
d98fda1
to
f711bd2
Compare
There was a problem hiding this comment.
Prebid doesn't allow adapters to make arbitrary requests - in this case event-tracking - but user-sync is another example. You may want to consider using a (or writing your own) analytics adapter http://prebid.org/overview/analytics.html
modules/medianetBidAdapter.js
Outdated
| @@ -24,15 +30,20 @@ function siteDetails(site) { | |||
| } | |||
|
|
|||
| function getPageMeta() { | |||
| if ($$PREBID_GLOBAL$$.medianetGlobals.pageMeta) { | |||
There was a problem hiding this comment.
Prebid no longer allows adapters to use the $$PREBID_GLOBAL$$ object. (though I notice you are already using it).
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi @mkendall07 @harpere , In reference to #2254, bidders weren't able to identify if their bids timed out, which is why we added onTimeout bidder API. Also to monitor bidders wins, we have onBidWon event. We have modeled our implementation based on the one built by sortable bid adapter It would be helpful if you can point the critical differences between our and their implementation which we can correct. Thanks. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi @mkendall07 @harpere , Any update on the same ? Thanks. |
|
@vedantseta |
vedantseta
force-pushed
the
pr-timeout-bidwon-event
branch
from
f711bd2
to
298c759
Compare
* Media.net bid adapter: firing logs on 'bidWon' and 'onTimeout' events * Media.net Bid Adapter: removed use of prebid global to save page meta data
* Media.net bid adapter: firing logs on 'bidWon' and 'onTimeout' events * Media.net Bid Adapter: removed use of prebid global to save page meta data
Type of change
Description of change
This PR adds Media.net support for utilising
onBidWonandonTimeoutevents. This also adds improvements by caching canonical, og, twitter URLs.