Update gumgumBidAdapter.md #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New zone and slot Ids were created for Prebid testing
jsnellbaker
requested changes
Sep 4, 2018
There was a problem hiding this comment.
Hi @susyt
I tested out these updated params using the hello_world.html page, but I wasn't getting ad content in the responses from the server.
Below is a copy of the request/response for both of the test params for reference. Could you take a look to see why the ads may not be returning?
inSlot: '15901' ad unit
request:
https://g2.gumgum.com/hbid/imp?si=15901&pi=3&gdprApplies=true&gdprConsent=null&vw=1680&vh=331&sw=1680&sh=1050&pu=http%3A%2F%2Fap.localhost%3A9999%2FintegrationExamples%2Fgpt%2Fhello_world.html%3Fpbjs_debug%3Dtrue&ce=true&dpr=2&
response:
{"ad":{},"pxs":{},"pag":{"t":"dc9d6be1"},"thms":10000}
inScreen: 'dc9d6be1' ad unit
request:
https://g2.gumgum.com/hbid/imp?t=dc9d6be1&pi=2&gdprApplies=true&gdprConsent=null&vw=1680&vh=331&sw=1680&sh=1050&pu=http%3A%2F%2Fap.localhost%3A9999%2FintegrationExamples%2Fgpt%2Fhello_world.html%3Fpbjs_debug%3Dtrue&ce=true&dpr=2&
response:
{"ad":{},"pxs":{},"pag":{"t":"dc9d6be1","pvid":"a5300e61-4165-4c79-8306-10a06ce334ce"},"thms":30000}
|
Hi @jsnellbaker - changes has been made to push through test ads to those parameters. |
|
@susyt Thanks for making the updates; I verified the new test params are working as expected now. LGTM |
jsnellbaker
approved these changes
Sep 5, 2018
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Sep 25, 2018
New zone and slot Ids were created for Prebid testing
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
New zone and slot Ids were created for Prebid testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New zone and slot ids were created for Prebid testing to consistently return test creatives. This PR updates the example in the documentation file
Other information
reference to issue #2937
@mxcoder