-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AOL adapter - switched to native Prebid user syncs support. #3032
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've still got one reference to PREBID_GLOBAL left which should be removed. Since this PR gets this bidder, gets the bidder much closer to compliance with the 1.x bidder rules, I'm approving it.
However, another PR should be made to remove the remaining PREBID_GLOBAL reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs merge conflicts resolved
@mike-chowla Hi. Requested changes are made. Could you please check that is wrong with the build on CircleCI. Seems like I don't have an access... Thanks. |
The Circle CI failure is appear unrelated to this PR and AOL adapter. All tests pass in my local. Here's the output from CircleCI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good now. Merge conflict is resolved.
Type of change
Description of change
Switched to native Prebid user syncs mechanism