Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AOL adapter - switched to native Prebid user syncs support. #3032

Merged
merged 3 commits into from
Sep 20, 2018
Merged

AOL adapter - switched to native Prebid user syncs support. #3032

merged 3 commits into from
Sep 20, 2018

Conversation

vzhukovsky
Copy link
Contributor

Type of change

  • Feature

Description of change

Switched to native Prebid user syncs mechanism

@stale
Copy link

stale bot commented Sep 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 12, 2018
mike-chowla
mike-chowla previously approved these changes Sep 15, 2018
View reviewed changes
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've still got one reference to PREBID_GLOBAL left which should be removed. Since this PR gets this bidder, gets the bidder much closer to compliance with the 1.x bidder rules, I'm approving it.

However, another PR should be made to remove the remaining PREBID_GLOBAL reference

@stale stale bot removed the stale label Sep 15, 2018
@mike-chowla mike-chowla dismissed their stale review September 15, 2018 00:35

Didn't notice the merge conflicts

mike-chowla
mike-chowla requested changes Sep 15, 2018
View reviewed changes
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs merge conflicts resolved

@vzhukovsky vzhukovsky closed this Sep 20, 2018
@vzhukovsky vzhukovsky deleted the contrib/aol-adapter-pixels branch September 20, 2018 12:45
@vzhukovsky vzhukovsky restored the contrib/aol-adapter-pixels branch September 20, 2018 12:48
@vzhukovsky vzhukovsky reopened this Sep 20, 2018
@vzhukovsky
Copy link
Contributor Author

vzhukovsky commented Sep 20, 2018 •
edited
Loading

@mike-chowla Hi.

Requested changes are made.

Could you please check that is wrong with the build on CircleCI. Seems like I don't have an access...

Thanks.

@mike-chowla
Copy link
Contributor

The Circle CI failure is appear unrelated to this PR and AOL adapter.

All tests pass in my local.

Here's the output from CircleCI:

  1. builds and sends auction data
    YuktaMedia analytics adapter track
    expected 2 to equal 1
    AssertionError@webpack:///node_modules/assertion-error/index.js:74 <- test/test_index.js:20449:22
    assert@webpack:///node_modules/chai/lib/chai/assertion.js:107 <- test/test_index.js:28202:31
    assertEqual@webpack:///node_modules/chai/lib/chai/core/assertions.js:487 <- test/test_index.js:28719:18
    webpack:///node_modules/chai/lib/chai/utils/addMethod.js:41 <- test/test_index.js:27789:30
    webpack:///test/spec/modules/yuktamediaAnalyticsAdaptor_spec.js:145:39 <- test/test_index.js:144856:50

mike-chowla
mike-chowla approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@mike-chowla mike-chowla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now. Merge conflict is resolved.

@mike-chowla mike-chowla merged commit 4baf2e4 into prebid:master Sep 20, 2018
ptomasroos pushed a commit to happypancake/Prebid.js that referenced this pull request Sep 25, 2018
@vzhukovsky @ptomasroos
AOL adapter - switched to native Prebid user syncs support. (prebid#3032
d0a1820 
)

* Switched to native Prebid user syncs support.

* Removed bid CPM adjustment warning to prevent using globals.
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
@vzhukovsky @StefanWallin
AOL adapter - switched to native Prebid user syncs support. (prebid#3032
35d05cb 
)

* Switched to native Prebid user syncs support.

* Removed bid CPM adjustment warning to prevent using globals.
SublimeJeremy pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Oct 1, 2018
@vzhukovsky @SublimeJeremy
AOL adapter - switched to native Prebid user syncs support. (prebid#3032
212a63a 
)

* Switched to native Prebid user syncs support.

* Removed bid CPM adjustment warning to prevent using globals.
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@vzhukovsky
AOL adapter - switched to native Prebid user syncs support. (prebid#3032
c470f3d 
)

* Switched to native Prebid user syncs support.

* Removed bid CPM adjustment warning to prevent using globals.
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
@vzhukovsky
AOL adapter - switched to native Prebid user syncs support. (prebid#3032
5c58f9d 
)

* Switched to native Prebid user syncs support.

* Removed bid CPM adjustment warning to prevent using globals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-chowla mike-chowla mike-chowla approved these changes

Assignees

@mike-chowla mike-chowla

Labels
needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vzhukovsky @mike-chowla