Update dgadsBidAdapter #3048
Merged
Update dgadsBidAdapter #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/dgadsBidAdapter.js # test/spec/modules/dgadsBidAdapter_spec.js
jsnellbaker
requested changes
Sep 10, 2018
There was a problem hiding this comment.
Hi @r-sato
The functional changes in the dgadsBidAdapter.js file look fine and appear to be working.
In regards to the updates in the _spec.js file, can you please revert the various arrow function changes and use the normal function declaration syntax?
There was a PR not long ago that made the numerous changes in the spec files to use this syntax since it's more compatible with Mocha (see #3036) - so we want to preserve this style.
|
Hi @jsnellbaker Thank you for the review. Please confirm that there is no differences in recognition. |
|
@r-sato thanks for making the updates; they LGTM |
jsnellbaker
approved these changes
Sep 10, 2018
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Sep 25, 2018
* Add dgads adapter * Add dgads adapter * Add spec file for dgads * Add spec file for dgads * Add dgads bid adapter * Add dgads bid adapter * fix * fix * fix email * remove semi-colon * Add mediaType native * Add import medaTypes * Change method to 'GET' and Change parameter name and Add get cookie. * fix camelcase * fix space * revert to normal function
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* Add dgads adapter * Add dgads adapter * Add spec file for dgads * Add spec file for dgads * Add dgads bid adapter * Add dgads bid adapter * fix * fix * fix email * remove semi-colon * Add mediaType native * Add import medaTypes * Change method to 'GET' and Change parameter name and Add get cookie. * fix camelcase * fix space * revert to normal function
SublimeJeremy
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Oct 1, 2018
* Add dgads adapter * Add dgads adapter * Add spec file for dgads * Add spec file for dgads * Add dgads bid adapter * Add dgads bid adapter * fix * fix * fix email * remove semi-colon * Add mediaType native * Add import medaTypes * Change method to 'GET' and Change parameter name and Add get cookie. * fix camelcase * fix space * revert to normal function
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Add dgads adapter * Add dgads adapter * Add spec file for dgads * Add spec file for dgads * Add dgads bid adapter * Add dgads bid adapter * fix * fix * fix email * remove semi-colon * Add mediaType native * Add import medaTypes * Change method to 'GET' and Change parameter name and Add get cookie. * fix camelcase * fix space * revert to normal function
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* Add dgads adapter * Add dgads adapter * Add spec file for dgads * Add spec file for dgads * Add dgads bid adapter * Add dgads bid adapter * fix * fix * fix email * remove semi-colon * Add mediaType native * Add import medaTypes * Change method to 'GET' and Change parameter name and Add get cookie. * fix camelcase * fix space * revert to normal function
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Add dgads adapter * Add dgads adapter * Add spec file for dgads * Add spec file for dgads * Add dgads bid adapter * Add dgads bid adapter * fix * fix * fix email * remove semi-colon * Add mediaType native * Add import medaTypes * Change method to 'GET' and Change parameter name and Add get cookie. * fix camelcase * fix space * revert to normal function
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Add dgads adapter * Add dgads adapter * Add spec file for dgads * Add spec file for dgads * Add dgads bid adapter * Add dgads bid adapter * fix * fix * fix email * remove semi-colon * Add mediaType native * Add import medaTypes * Change method to 'GET' and Change parameter name and Add get cookie. * fix camelcase * fix space * revert to normal function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Change method to 'GET' and Change parameter name.
And add "getCookie" to link with other services.