Fix #3059 by returning both hb_deal and hb_deal_${bidder_code} #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Sep 10, 2018
harpere
added
needs 2nd review
harpere
added
LGTM
and removed
needs 2nd review
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Sep 25, 2018
…rebid#3062) * Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} * Add unit test per @mkendall07
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
…rebid#3062) * Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} * Add unit test per @mkendall07
SublimeJeremy
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Oct 1, 2018
…rebid#3062) * Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} * Add unit test per @mkendall07
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…rebid#3062) * Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} * Add unit test per @mkendall07
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
…rebid#3062) * Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} * Add unit test per @mkendall07
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…rebid#3062) * Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} * Add unit test per @mkendall07
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…rebid#3062) * Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} * Add unit test per @mkendall07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Per #3059, the targeting key
hb_dealis being replaced byhb_deal_${bidder_code}rather than both being sent. This pull will change the logic ofgetWinningBidTargetingto return bothhb_dealandhb_deal_${bidder_code}Other information
Fixes #3059 per @snapwich's report. + @mkendall07 and @jaiminpanchal27