Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TripleliftBidAdapter - remove dependency on getTopWindowLocation util #3139

Merged
merged 8 commits into from
Nov 7, 2018
+41 −10
Merged

TripleliftBidAdapter - remove dependency on getTopWindowLocation util #3139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
57a0658
removed dependancy on getTopWindowUrl for referer
brittanyzellman Sep 28, 2018
5af1dc3
protect against undefined obj and remove test on old dependency
brittanyzellman Sep 28, 2018
e29e5b6
added unit test for referer and gdpr in query string
brittanyzellman Oct 23, 2018
af59596
removed gdpr test
brittanyzellman Oct 23, 2018
f1dfed2
removed gdpr from bidderRequest obj
brittanyzellman Oct 23, 2018
5908387
decontructed bidder request obj in chai test
brittanyzellman Oct 24, 2018
91ad9d2
just need to run karma tests again
brittanyzellman Oct 24, 2018
16195df
added gdpr consent to all bidderRequest obj in chai tests
brittanyzellman Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions modules/tripleliftBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,15 @@ export const tripleliftAdapterSpec = {

buildRequests: function(bidRequests, bidderRequest) {
let tlCall = STR_ENDPOINT;
let referrer = utils.getTopWindowUrl();
let data = _buildPostBody(bidRequests);

tlCall = utils.tryAppendQueryString(tlCall, 'lib', 'prebid');
tlCall = utils.tryAppendQueryString(tlCall, 'v', '$prebid.version$');
tlCall = utils.tryAppendQueryString(tlCall, 'referrer', referrer);

if (bidderRequest && bidderRequest.refererInfo) {
let referrer = bidderRequest.refererInfo.referer;
tlCall = utils.tryAppendQueryString(tlCall, 'referrer', referrer);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but should add a unit test.


if (bidderRequest && bidderRequest.timeout) {
tlCall = utils.tryAppendQueryString(tlCall, 'tmax', bidderRequest.timeout);
Expand Down
44 changes: 36 additions & 8 deletions test/spec/modules/tripleliftBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,19 +68,42 @@ describe('triplelift adapter', function () {
}
];

let bidderRequest = {
bidderCode: 'triplelift',
auctionId: 'a7ebcd1d-66ff-4b5c-a82c-6a21a6ee5a18',
bidderRequestId: '5c55612f99bc11',
bids: [
{
imp_id: 0,
cpm: 1.062,
width: 300,
height: 250,
ad: 'ad-markup',
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg'
}
],
refererInfo: {
referer: 'http://examplereferer.com'
},
gdprConsent: {
consentString: 'BOONm0NOONm0NABABAENAa-AAAARh7______b9_3__7_9uz_Kv_K7Vf7nnG072lPVA9LTOQ6gEaY',
gdprApplies: true
}
};

it('exists and is an object', function () {
const request = tripleliftAdapterSpec.buildRequests(bidRequests);
const request = tripleliftAdapterSpec.buildRequests(bidRequests, bidderRequest);
expect(request).to.exist.and.to.be.a('object');
});

it('should only parse sizes that are of the proper length and format', function () {
const request = tripleliftAdapterSpec.buildRequests(bidRequests);
const request = tripleliftAdapterSpec.buildRequests(bidRequests, bidderRequest);
expect(request.data.imp[0].banner.format).to.have.length(2);
expect(request.data.imp[0].banner.format).to.deep.equal([{w: 300, h: 250}, {w: 300, h: 600}]);
});

it('should be a post request and populate the payload', function () {
const request = tripleliftAdapterSpec.buildRequests(bidRequests);
const request = tripleliftAdapterSpec.buildRequests(bidRequests, bidderRequest);
const payload = request.data;
expect(payload).to.exist;
expect(payload.imp[0].tagid).to.equal('12345');
Expand All @@ -89,16 +112,15 @@ describe('triplelift adapter', function () {
});

it('should return a query string for TL call', function () {
const request = tripleliftAdapterSpec.buildRequests(bidRequests);
const request = tripleliftAdapterSpec.buildRequests(bidRequests, bidderRequest);
const url = request.url;
expect(url).to.exist;
expect(url).to.be.a('string');
expect(url).to.match(/(?:tlx.3lift.com\/header\/auction)/)
expect(url).to.match(/(?:lib=prebid)/)
expect(url).to.match(/(?:prebid.version)/)
// expect(url).to.match(/(?:fe=)/) //
expect(url).to.match(/(?:referrer)/)
})
expect(url).to.match(/(?:referrer)/);
});
});

describe('interpretResponse', function () {
Expand Down Expand Up @@ -130,8 +152,11 @@ describe('triplelift adapter', function () {
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg'
}
],
refererInfo: {
referer: 'http://examplereferer.com'
},
gdprConsent: {
consentString: 'BOONm0NOONma-AAAARh7______b9_3__7_9uz_Kv_K7Vf7nnG072lPVOQ6gEaY',
consentString: 'BOONm0NOONm0NABABAENAa-AAAARh7______b9_3__7_9uz_Kv_K7Vf7nnG072lPVA9LTOQ6gEaY',
gdprApplies: true
}
};
Expand Down Expand Up @@ -201,6 +226,9 @@ describe('triplelift adapter', function () {
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg'
}
],
refererInfo: {
referer: 'http://examplereferer.com'
},
gdprConsent: {
consentString: 'BOONm0NOONm0NABABAENAa-AAAARh7______b9_3__7_9uz_Kv_K7Vf7nnG072lPVA9LTOQ6gEaY',
gdprApplies: true
Expand Down