OpenXOutstream Bid Adapter #3153

HolzAndrew · 2018-10-03T15:12:33Z

Type of change

[x ] New bidder adapter

Description of change

Adds an openxoutstream adapter

test parameters for validating bids

{
  bidder: 'openxoutstream',
  params: {
    unit: '53943996499',
    delDomain: 'se-demo-d.openx.net',
    publisher_page_url: 'yieldmo.com',
    width:  '300',
     height: '250',
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

HolzAndrew · 2018-10-03T15:16:10Z

@merrdy @jasminenoack @harquail @elberdev

modules/openxoutstreamBidAdapter.js

harquail · 2018-10-03T15:24:09Z

package-lock.json

@@ -1,6 +1,6 @@
 {


was this changed intentionally?

harquail · 2018-10-03T15:28:40Z

modules/openxoutstreamBidAdapter.md

+
+# Description
+
+Module that connects to OpenX's demand sources for outstream


description could be more complete — also do we need to mention Yieldmo here?

precedent on the other adapters is that this is just a short sentence. I've added Yieldmo to the line though now.

@harquail is this sufficient?

modules/openxoutstreamBidAdapter.js

mkendall07 · 2018-10-03T15:30:01Z

This pull request introduces 1 alert when merging b97e12b into e7ad006 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

Comment posted by LGTM.com

modules/openxoutstreamBidAdapter.js

mkendall07 · 2018-10-03T15:44:16Z

This pull request introduces 1 alert when merging dc48ab9 into e7ad006 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

Comment posted by LGTM.com

HolzAndrew · 2018-10-03T16:22:46Z

@bwoolcott

modules/openxoutstreamBidAdapter.js

…ation.

modules/openxoutstreamBidAdapter.js

test/spec/modules/openxoutstreamBidAdapter_spec.js

ghost · 2018-10-08T20:10:39Z

modules/openxoutstreamBidAdapter.md

+```
+Module Name: OpenX Outstream Bidder Adapter
+Module Type: Bidder Adapter
+Maintainer: opensource@yieldmo.com


Adding jimmy.tu@openx.com

HolzAndrew · 2018-10-09T17:41:05Z

@jaiminpanchal27 all done with edits and ready for review! thanks!

jaiminpanchal27 · 2018-10-15T19:56:56Z

@HolzAndrew
Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

HolzAndrew · 2018-10-15T20:29:13Z

@jaiminpanchal27 thank you for reviewing. please see pr to dev-docs here: prebid/prebid.github.io#999

Thanks!

@97

* Make size mapping mediaType aware (prebid#3134) * make sizeMapping mediaTypes aware * no sizeMapping if the only mediaType is not banner * better logging for size mapping and no auction when no bids * fix size mapping tests to ignore filter results (which are only for logging) * Making targeting keys configurable (prebid#3140) * moved NATIVE_KEYS to constants * Changed TARGETING_KEYS from array to an array - Now you can change key names - Made changes in code at auction.js and targeting.js to handle the TARGETING_KEYS object than array * fixed aauctionmanager test cases for dynamic targeting key names * fixed native test cases for dynamic targeting key names * fixed test cases of targeting for dynamic targeting key names * in-dev changes * replace old keys with new keys * fixed a typo * fixed a unit case in utils * updated convertTargetingsFromOldToNew in fixtures this will now replace partner specific keys as well as per config * removed a log * keep test case as it was * improved convertTargetingsFromOldToNew in fixtures * Capitalized key names in TARGETING_KEYS object; not values in object * using computed properties * using computed properties * fixed eslint suggestion * fixed eslint suggestions * keeping unit tests more compliant with Mocha * 4235 prebid endpoint return empty array instead of 204 when no bids returned (prebid#3136) * corrected user sync type * add alias pxyz add version to endpoint add validation for 204 bid response * add validation with serverResponse is undefined fix test for 204 (no bid response) * remove package lock * restore package-lock * update gulp 4 notes on README (prebid#3154) * Add teads bidder adapter (prebid#3135) * Add teads bidder adapter * Remove bidder code & tests arrow functions * Added the option to pass a deal id instead of a partnership id (prebid#3148) * increment Prebid version * Prebid 1.26.0 release * increment prebid version * implement find polyfill in unit test (prebid#3156) * InvibesBidAdapter - gdpr support (prebid#3151) * removed `cookieSyncDelay` from `config` since we have more configuration options now with the `userSync` object (prebid#3142) * Livewrapped bid and analytics adapter (prebid#3157) * Livewrapped bid and analytics adapter * Fixed some tests for browser compatibility * Fixed some tests for browser compatibility * Changed analytics adapter code name * Fix double quote in debug message * Adding appnexus debug via cookie/params (prebid#3152) * adding appnexus debug via cookie/params * removing nested object * added documentation link and removed useless conditional * fix lint error on documentation message * Add RSA validation to Criteo FastBid (prebid#3110) * Pass Prebid version to Criteo direct bidder * Update Criteo profile IDs * Add RSA verification to Criteo FastBid * Update package-lock with jsencrypt and crypto-js * Replacing all arrow functions in Mocha function calls * Update Adapter Version to 14 * Added support for user syncing pixel (prebid#3092) * Added Polymorph adapter * Cleaned up code * Updated var to let * Updated with mediaType * Updated tests * Fixed tests * Updated polymorph adapter to support cookie syncing and network key integration * Fixed parens for lint * Fixed a bug related to network_key approach * Fixed double negation warning * Updated tests for network_key * Added bidId as cache buster and updated tests * Fixed tests * Small bugfix and cleanup for Prebid Server OpenRTB code (prebid#3113) * change bid map to bid_id map and clean up openrtb in pbs * add src to bids in bid request when known * Revert "Adding appnexus debug via cookie/params" (prebid#3164) * Revert "Small bugfix and cleanup for Prebid Server OpenRTB code (prebid#3113)" This reverts commit a1f07e9. * Revert "Added support for user syncing pixel (prebid#3092)" This reverts commit 8fdf61d. * Revert "Add RSA validation to Criteo FastBid (prebid#3110)" This reverts commit e72e2dc. * Revert "Adding appnexus debug via cookie/params (prebid#3152)" This reverts commit 4797ea2. * add bid ttl to cache call (prebid#3163) * Render outstream safeframe (prebid#3159) * render outstream safeframe * move code to Renderer module * some more logic to move * Prebid 1.27.0 Release * increment Prebid version * rubiconBidAdapter - Checking FPD values are defined before toString() (prebid#3165) * rubiconBidAdapter - Checking FPD values are defined before toString() - Added two tests for this behavior * Removing unused variable * changed to compare against null added some null params to the tests to verify * Adding mediaType param to parseSizes in order to ALWAYS get the correct parse Size method correct. (prebid#3166) * PubMatic to support DigiTrust Id passing (prebid#3160) * in-dev changes * included config * Unit test cases for DigitrustId passing in PubMatic bid adapter * eslint fixes * removed a comment * replaced "() => {" with "() => {" * OpenX Adapter: Added support for pubcid (prebid#3158) * use version replace rather than package.json in widespace (prebid#3143) * Trafficroots Resubmit (prebid#3141) circleci is still failing, but I cannot find a workaround for this PR at the moment * Rubicon skip video request in mutlti format when video is not setup (prebid#3167) * Update rubiconBidAdapter.js * OpenXOutstream Bid Adapter (prebid#3153) * adds openxoutstreamadapter files * cleans up url, adds bidder config and version, removes unused code * updates template ad response * remove final unused custom param code * add openrtb to list of params again. * add payload back so we can read bidId * extra checks for cpm (pub_rev) * adds unit tests * adds unit tests * update md page * undo openx adapter space changes from autosave * undo openx adapter space changes from autosave * test cleanup * test cleanup * update md file * update example page params * remove sneaky console.log * return false * adds yieldmo to the md. remove useless docEl assignment * remove useless docEl assignments * move crid and adid to constants * fix test * remove another useless variable assignment caught by LGTM * changes CR_ID. moves tdoc to within if scope * updates crid on test * use more constants and use crid for lfid * remove superfluous trailing argument * adds viewport meta tag to header. removes unnecessary string interpolation. * move ad_id to a string * undo changes for pacakge-lock * fixes lfid to lfId, pID to pId * fixes lfid to lfId, pID to pId * remove rti:1 * adds openx maintainer email * improves additional data passed to the handler in AuctionInit and AuctionEnd events (prebid#3168) * removing cookieSet (prebid#3175) * removing cookieSet * removing blank line * not including src/cookie anymore * Removed deprecated priceType option (+tests) (prebid#3170) * Improve Digital adapter: set dealID based on buying type (prebid#3182) * Adding GDPR support * Always drop user syncs when available * Set dealID based on buying type * disabling tests that are failing in safari (prebid#3186) * Prebid 1.28.0 Release * Increment pre version * RVR-1124 Setup initial skeleton analytics adapter that can send something. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Formatted auction/events data to fit needed schema. * RVR-1135 fetched device data. * Applied feedback. * Applied feedback. * Fetched core. * Added click handler for reporting banners click events. * Applied analyzer for reporting displayed impressions. * Applied feedback. * Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7) RVR-1214 Invoke handlers on rendering * RVR-1214 Invoked handlers right after ad is displayed. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1192-configuration-global-parameters (pull request #8) RVR-1192 Configuration/Global parameters Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6) RVR-1181 Prebid.js Unit tests setup Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1247-additional-data-to-impression-records (pull request #9) RVR-1247 Additional data to impression records Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1249-add-requestedbids-to-auction (pull request #10) RVR-1249 Add requested bids to auction object request. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1261-fix-tests (pull request prebid#11) RVR-1261 fix tests * RVR-1261 Secured adapter from no containers configuration. And changed fetching URL. * RVR-1261 Added event check for request and changed some names. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * RVR-1352 analytics adapter bugs Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Fixed bug with geolocation notification. * fixed missing bracket. * one more fix. * RVR-1357 Different optimisation responses & tracking into auction event * RVR-1852 - Add content type and hardcoded auth headers (cherry picked from commit 4def881) * RVR-1852 - Change tracker host * RVR-1852 - Override content type instead of adding header * districtmDMX new adapter (prebid#2765) * adding DMX test @97%, two files added one updated * Update districtm_spec.js * Update districtmDMX.js * adding all districtm needed file * remove legacy file * remove typo || 0 in the test method * force default to return a valid width and height * update unit test code for failing test * changed class for an object * remove package-lock.json * upgrade to gulp 4 (prebid#2930) * upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task * RVR-1914 Consistent data types in events Also removes undefined and null properties in audience events * Merged in RVR-1883-Add-Basic-Access-Authentication (pull request prebid#17) RVR-1883 Add Basic Access Authentication * RVR-1914 - Rename functions * RVR-1914 - Set default total_duration to null in bid response * RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token * RVR-1883 - Restore stub after every test not just at the end * RVR-1883 - Remove commented code * Increase code coverage * Fix for IE 11.0.0 and Safari 8.0.8 - includes() Use core-js includes function for array

* adds openxoutstreamadapter files * cleans up url, adds bidder config and version, removes unused code * updates template ad response * remove final unused custom param code * add openrtb to list of params again. * add payload back so we can read bidId * extra checks for cpm (pub_rev) * adds unit tests * adds unit tests * update md page * undo openx adapter space changes from autosave * undo openx adapter space changes from autosave * test cleanup * test cleanup * update md file * update example page params * remove sneaky console.log * return false * adds yieldmo to the md. remove useless docEl assignment * remove useless docEl assignments * move crid and adid to constants * fix test * remove another useless variable assignment caught by LGTM * changes CR_ID. moves tdoc to within if scope * updates crid on test * use more constants and use crid for lfid * remove superfluous trailing argument * adds viewport meta tag to header. removes unnecessary string interpolation. * move ad_id to a string * undo changes for pacakge-lock * fixes lfid to lfId, pID to pId * fixes lfid to lfId, pID to pId * remove rti:1 * adds openx maintainer email

yieldmoholz added 15 commits October 1, 2018 17:11

adds openxoutstreamadapter files

3c7f4e4

cleans up url, adds bidder config and version, removes unused code

59dc937

updates template ad response

70f2a1f

remove final unused custom param code

b51a8d7

add openrtb to list of params again.

6572f25

add payload back so we can read bidId

a8c32e4

extra checks for cpm (pub_rev)

d9db875

adds unit tests

42e0944

adds unit tests

796a6ed

update md page

2b5ffda

undo openx adapter space changes from autosave

fad4270

undo openx adapter space changes from autosave

1cf4eac

test cleanup

b9e2de9

test cleanup

1a184d6

update md file

b7a8f2d

update example page params

b97e12b

MelodyLi2017 reviewed Oct 3, 2018

View reviewed changes

modules/openxoutstreamBidAdapter.js Show resolved Hide resolved

harquail suggested changes Oct 3, 2018

View reviewed changes

MelodyLi2017 reviewed Oct 3, 2018

View reviewed changes

modules/openxoutstreamBidAdapter.js Outdated Show resolved Hide resolved

MelodyLi2017 reviewed Oct 3, 2018

View reviewed changes

modules/openxoutstreamBidAdapter.js Outdated Show resolved Hide resolved

harquail reviewed Oct 3, 2018

View reviewed changes

modules/openxoutstreamBidAdapter.js Outdated Show resolved Hide resolved

yieldmoholz added 2 commits October 3, 2018 11:32

remove sneaky console.log

218aff7

return false

dc48ab9

adds yieldmo to the md. remove useless docEl assignment

ec36979

ghost reviewed Oct 3, 2018

View reviewed changes

modules/openxoutstreamBidAdapter.js Outdated Show resolved Hide resolved

remove useless docEl assignments

f2faa09

jasminenoack suggested changes Oct 3, 2018

View reviewed changes

modules/openxoutstreamBidAdapter.js Outdated Show resolved Hide resolved

modules/openxoutstreamBidAdapter.js Outdated Show resolved Hide resolved

modules/openxoutstreamBidAdapter.js Outdated Show resolved Hide resolved

modules/openxoutstreamBidAdapter.js Show resolved Hide resolved

yieldmoholz added 2 commits October 3, 2018 15:20

adds viewport meta tag to header. removes unnecessary string interpol…

31a9580

…ation.

move ad_id to a string

f0dcec2

elberdev reviewed Oct 3, 2018

View reviewed changes

yieldmoholz added 3 commits October 3, 2018 16:48

undo changes for pacakge-lock

2b8c93f

fixes lfid to lfId, pID to pId

c49c56d

fixes lfid to lfId, pID to pId

5c64b0f

MelodyLi2017 approved these changes Oct 4, 2018

View reviewed changes

elberdev approved these changes Oct 4, 2018

View reviewed changes

harquail approved these changes Oct 4, 2018

View reviewed changes

mike-chowla assigned jaiminpanchal27 Oct 5, 2018

remove rti:1

af85415

ghost approved these changes Oct 8, 2018

View reviewed changes

adds openx maintainer email

96a5e76

jasminenoack approved these changes Oct 8, 2018

View reviewed changes

bwoolcott added the needs review label Oct 10, 2018

jaiminpanchal27 approved these changes Oct 15, 2018

View reviewed changes

jaiminpanchal27 added LGTM and removed needs review labels Oct 15, 2018

jaiminpanchal27 added the needs docs label Oct 15, 2018

jaiminpanchal27 merged commit cb66860 into prebid:master Oct 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenXOutstream Bid Adapter #3153

OpenXOutstream Bid Adapter #3153

HolzAndrew commented Oct 3, 2018 •

edited

Loading

HolzAndrew commented Oct 3, 2018

harquail Oct 3, 2018

harquail Oct 3, 2018

HolzAndrew Oct 3, 2018

HolzAndrew Oct 4, 2018

harquail Oct 4, 2018

mkendall07 commented Oct 3, 2018

mkendall07 commented Oct 3, 2018

HolzAndrew commented Oct 3, 2018

ghost Oct 8, 2018

HolzAndrew commented Oct 9, 2018

jaiminpanchal27 commented Oct 15, 2018

HolzAndrew commented Oct 15, 2018


		# Description

		Module that connects to OpenX's demand sources for outstream

OpenXOutstream Bid Adapter #3153

OpenXOutstream Bid Adapter #3153

Conversation

HolzAndrew commented Oct 3, 2018 • edited Loading

Type of change

Description of change

Other information

HolzAndrew commented Oct 3, 2018

harquail Oct 3, 2018

Choose a reason for hiding this comment

harquail Oct 3, 2018

Choose a reason for hiding this comment

HolzAndrew Oct 3, 2018

Choose a reason for hiding this comment

HolzAndrew Oct 4, 2018

Choose a reason for hiding this comment

harquail Oct 4, 2018

Choose a reason for hiding this comment

mkendall07 commented Oct 3, 2018

mkendall07 commented Oct 3, 2018

HolzAndrew commented Oct 3, 2018

ghost Oct 8, 2018

Choose a reason for hiding this comment

HolzAndrew commented Oct 9, 2018

jaiminpanchal27 commented Oct 15, 2018

HolzAndrew commented Oct 15, 2018

HolzAndrew commented Oct 3, 2018 •

edited

Loading