Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #2822 - Improve Uniqueness of UUID with Crypto API when Available #3162

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Fix for #2822 - Improve Uniqueness of UUID with Crypto API when Available #3162

merged 1 commit into from
Oct 26, 2018

Conversation

GLStephen
Copy link
Collaborator

@GLStephen GLStephen commented Oct 9, 2018 •
edited
Loading

  • Bugfix

Fix for #2822

Description of change

Change ended up being pretty straightforward. It introduces a new function _getRandomData() in utils which the existing generateUUID() function calls for the random data component.

The code change has been tested in our PubWise test environment, and some live traffic.

In terms of performance, the crypto method is slightly slower. Performance below for 1000 unique IDs. 20ms vs <10 ms

11:08:25.729 crypto 1000 run start true
11:08:25.731 index.html:31 crypto 1000 run end
11:08:25.731 index.html:34 math 1000 run start false
11:08:25.731 index.html:38 math 1000 end

A 100,000 run starts to show observable time at the 10 millisecond resolution in Math.random, but also a small time for Crypto. 60ms vs. 20ms.

11:09:55.103 crypto 1000 run start true
11:09:55.109 index.html:31 crypto 1000 run end
11:09:55.109 index.html:34 math 1000 run start false
11:09:55.111 index.html:38 math 1000 end

All existing tests remain functional and unchanged.

SUMMARY:
✔ 2690 tests completed
ℹ 1 test skipped
TOTAL: 2690 SUCCESS

============= Coverage summary ===============================
Statements : 88.93% ( 14437/16234 )
Branches : 76.27% ( 8395/11007 )
Functions : 90.64% ( 2565/2830 )
Lines : 89.12% ( 14104/15825 )
=============+============================================

Observable testing of exhaustive global uniqueness is challenged. We've ran large batches of keys and verified uniqueness within multiple runs and in test data and the method chosen has acceptance in the wider dev community and comes from here: https://gist.github.com/jed/982883#gistcomment-45104

Example UUIDs Generated by these Functions in Both Modes.

Crypto

11:12:59.970 index.html:27 crypto 100 run start true
11:12:59.971 index.html:29 21776bc0-ba49-4ef5-93e2-6199dd2c981b
11:12:59.972 index.html:29 3cdbe40d-95d1-401c-a8c4-5c6a75ac7286
11:12:59.972 index.html:29 93562869-a16c-4c92-ac0c-6651f0e2bb94
11:12:59.972 index.html:29 a45662ff-aefa-4059-80d5-f78c682b21d8
11:12:59.972 index.html:29 ac3b8260-34c5-44ba-abae-1a4d455d5a34
11:12:59.972 index.html:29 d1cd05ee-17ba-4a67-a979-a252950e538d
11:12:59.973 index.html:29 e96cded4-bda9-46a4-b3b2-a362416ca97a
11:12:59.973 index.html:29 a3b1068a-4d9a-42a7-9de0-10bb93cd7600
11:12:59.973 index.html:29 4494e1f0-b2ef-4723-9f7f-0834734d3961
11:12:59.973 index.html:29 b4f6bb86-21bf-4ccb-9701-40781c60219e
11:12:59.973 index.html:29 7167970b-963b-4c2e-8b73-af93b13e1bc7
11:12:59.974 index.html:29 74328992-2b26-49a8-87a9-d9cf30089909
11:12:59.974 index.html:29 37035c65-e34c-4c08-a0f7-970924cc118a
11:12:59.974 index.html:29 f578246c-eaf3-4d72-9076-c9389dc9ca40
11:12:59.974 index.html:29 984c7f7c-38ea-4035-9dcd-cc4b6097b3ba
11:12:59.975 index.html:29 775fac2c-7ca7-4137-874e-89947e21946b
11:12:59.975 index.html:29 5bbbefd8-a061-48bd-b52a-7967f73ea79c
11:12:59.975 index.html:29 5429fe21-8fcf-47e9-b1b7-18414d8fc573
11:12:59.975 index.html:29 e9cd7eb5-81fc-4d0f-addb-4bc4883d173f
11:12:59.975 index.html:29 c4b02425-5f5c-49e6-ad5f-0336e5161884
11:12:59.975 index.html:29 244dcd89-a4ed-48b3-9a27-e700a269f88b
11:12:59.975 index.html:29 bb311189-7577-4acb-8938-5ce3ced84cfc
11:12:59.976 index.html:29 5acbff81-7523-40da-b171-8cc147b8cbcc
11:12:59.977 index.html:29 8bf11e68-2c21-47bf-bb16-2c9445f75109
11:12:59.977 index.html:29 6e723c27-55ab-4c07-b1ef-90e6e511d017
11:12:59.977 index.html:29 70584987-3ace-464f-aa47-d8335e2506c9
11:12:59.977 index.html:29 a5b232e0-9991-4daa-8912-3f7a088b6ebe
11:12:59.977 index.html:29 db993c2e-1979-402c-ac87-83cb59a406c4
11:12:59.977 index.html:29 5f8ec28d-370f-44f1-8be6-1876cac89758
11:12:59.977 index.html:29 bf2c99a6-d4dc-4f60-874d-b35c3b85fcaa
11:12:59.978 index.html:29 7b9a9163-965b-4f93-ad43-febe5ce9daf0
11:12:59.978 index.html:29 966b29bf-ba7c-4d05-a781-70e7a8bce919
11:12:59.978 index.html:29 da0a3851-0bf4-4222-ab8f-19ac2d97818f
11:12:59.978 index.html:29 2f45ed08-ab02-49f7-b255-b776c009ee1b
11:12:59.978 index.html:29 4d3c7937-db36-4800-8e12-08e6f7b12e0c
11:12:59.978 index.html:29 8cc9a60c-ead4-4eb2-af4f-f6fb33615b2a
11:12:59.978 index.html:29 7e257a4b-c49e-45d0-83af-2370c6b5c0fa
11:12:59.978 index.html:29 124eaa3f-44f8-4bd2-af21-655985aceb1c
11:12:59.979 index.html:29 e068bcb0-1acd-444c-ba4f-a2117bdf80ea
11:12:59.979 index.html:29 13b8ed55-ba6e-4a85-a070-a6df1ceefddb
11:12:59.979 index.html:29 0739bc2e-21e1-47cb-be67-54bd01b11e61
11:12:59.979 index.html:29 a8b0e950-eaa8-4eb2-b229-3da295050912
11:12:59.979 index.html:29 d5a9eba2-e6ca-4f45-abf1-93dc415f869a
11:12:59.979 index.html:29 22b3b123-e29a-4a67-ba1b-14440dceb289
11:12:59.979 index.html:29 e596183b-690c-4e83-8d7c-db1f3cb79f26
11:12:59.980 index.html:29 9350c0ba-5a08-4dda-8f80-04edf5ec727c
11:12:59.980 index.html:29 36a61b01-192c-4412-8f62-53d4f50a3ac5
11:12:59.980 index.html:29 db83a595-6070-4301-b25c-9e9b51277a2c
11:12:59.980 index.html:29 f02cb465-a180-4fd3-a964-08fd5866c1dd
11:12:59.980 index.html:29 40f94d59-9950-4859-81da-7364d1d89ad9
11:12:59.980 index.html:29 4354b3aa-ceca-4033-ad32-4832fae4f974
11:12:59.980 index.html:29 8af2b0ca-cf84-454b-98b7-991ac01dc6d1
11:12:59.980 index.html:29 3d5088a9-45b6-48d0-a985-5142a882b302
11:12:59.981 index.html:29 fadbaead-1241-49e8-896c-998f75167042
11:12:59.981 index.html:29 a4e79cc3-08c9-40e3-8648-4a39f3b3be51
11:12:59.981 index.html:29 fadb1aa3-1195-458e-a20b-032826be1ce8
11:12:59.981 index.html:29 a6c10d1b-3dc3-4ba0-855d-a1c3a1e6e072
11:12:59.981 index.html:29 689dd5a2-3dd0-4d69-99da-58676db99232
11:12:59.981 index.html:29 00efb39c-06c1-4fc2-a8d2-d077cb8b2fd8
11:12:59.981 index.html:29 d451981c-2b87-4977-bc05-406030c0e39e
11:12:59.982 index.html:29 3bce1b1e-6d24-4e82-a2c1-771e8419c504
11:12:59.982 index.html:29 ddc4e183-d5f0-4ae4-b502-443010af9edd
11:12:59.982 index.html:29 4a82f5d9-bb73-4a1f-b245-836de0f812ef
11:12:59.982 index.html:29 07328c2a-65e0-4b6c-a4f6-83eace733b3c
11:12:59.982 index.html:29 61ec7d16-2070-4305-b685-7981aeb14d0e
11:12:59.982 index.html:29 be4fe2d3-8cfb-45fd-99b5-fcdf33aecd51
11:12:59.982 index.html:29 26f50294-a55d-4f6a-a4d5-823ee5bebc2a
11:12:59.983 index.html:29 9d65a93f-5636-4db7-befe-512cf5bd7c59
11:12:59.983 index.html:29 fad02287-4215-4d51-985c-2236eb2ec76f
11:12:59.983 index.html:29 9d9892a5-17a0-427f-a1fe-4d69cb080ec2
11:12:59.983 index.html:29 ac626e05-a8c2-4568-a46f-d153f1893de2
11:12:59.983 index.html:29 38634534-3fe6-4378-8042-33b2d843efc1
11:12:59.983 index.html:29 903c25eb-defa-4966-adb5-6fc1d838865e
11:12:59.983 index.html:29 b41e5d94-9b32-47e0-8340-ca012b414cde
11:12:59.983 index.html:29 a32d8eaa-d7d4-42c1-baae-e5138bcd81cb
11:12:59.984 index.html:29 61483061-5389-4290-9e39-16c99139c6ca
11:12:59.984 index.html:29 daa60d89-86f1-48ac-be40-b208e2d308ac
11:12:59.984 index.html:29 4e2f244b-b963-42b6-a0b0-5b117841302e
11:12:59.984 index.html:29 b39486e9-8271-4d1f-aa2f-fc73b44a3b29
11:12:59.987 index.html:29 f00dac25-e05c-4def-9991-7148ceb7d8f4
11:12:59.987 index.html:29 906028a0-85ba-45b7-9e58-09ad15a808ad
11:12:59.987 index.html:29 49a164a6-7241-4c4c-8e4f-3ad65cd9b732
11:12:59.987 index.html:29 4118d331-fa8a-4a2f-a7be-9edbf2d1552f
11:12:59.988 index.html:29 c8d3c861-37f2-4e8c-b2dc-c2b69da93508
11:12:59.988 index.html:29 fe8e6d91-42d3-49f1-bb12-5012fcfcb72e
11:12:59.988 index.html:29 40a0f761-1fa9-45ae-b40b-b874ac250d9e
11:12:59.988 index.html:29 f4567bfb-22b6-449a-84be-b75400bd463d
11:12:59.988 index.html:29 62fa133c-9765-4b0f-90cd-6cff0255bd20
11:12:59.988 index.html:29 f1a5cb2a-7304-495a-b5d3-17f5d3f35421
11:12:59.988 index.html:29 6d727548-2ad6-4a5c-af4f-b2aa9f0f9e3f
11:12:59.988 index.html:29 e180fca8-f91a-4d2e-81c3-7bd2d337c5c3
11:12:59.989 index.html:29 1a83dda7-a0d3-4fda-8337-571b564385e3
11:12:59.989 index.html:29 3a7dc387-a3a2-41e3-a985-e772f06603f8
11:12:59.989 index.html:29 b40fa021-3a28-4084-a47d-0f06154e66f2
11:12:59.989 index.html:29 56abc5a1-6e4b-46ba-87e9-a08f0906f7fa
11:12:59.989 index.html:29 c7d2176c-b790-4acb-a170-c1d0dfd145b4
11:12:59.989 index.html:29 da5b7d03-e257-4bc7-842e-4c37446bb152
11:12:59.989 index.html:29 ccfaeee1-94eb-4c31-9532-19b5ef71fc56
11:12:59.990 index.html:29 7bdad99d-be86-4bc0-8531-e3b438801e41
11:12:59.990 index.html:29 5203c65d-0b6f-4ff5-8daf-ca20dfc55838
11:12:59.990 index.html:31 crypto 1000 run end

Math.random

11:12:59.990 index.html:34 math 100 run start false
11:12:59.990 index.html:36 250f9ef6-847b-4078-aa6d-cc3c00996a1e
11:12:59.990 index.html:36 5cd7d746-6d68-4a07-ad0f-db547e93a516
11:12:59.990 index.html:36 e4199a99-2fe4-48fe-9146-ed22ae62a0b2
11:12:59.990 index.html:36 66686690-f3b8-456f-b8d5-2e95848dc233
11:12:59.990 index.html:36 0b929104-b11e-447a-b5fa-fcc91d6a56ae
11:12:59.990 index.html:36 faea9a47-ec9b-4300-ae3f-8bb3cefa0296
11:12:59.991 index.html:36 04b863c1-0d85-4f11-9139-691e25f8ba79
11:12:59.991 index.html:36 55bcb12f-0723-477b-81eb-16f1c816c187
11:12:59.991 index.html:36 b92a8b26-ac8e-4728-9cea-c54c8436603c
11:12:59.991 index.html:36 01a9831d-cacd-4a39-acb2-126ed47a5834
11:12:59.991 index.html:36 ab43c4a5-1b04-4ae8-a045-acc21c480d2c
11:12:59.991 index.html:36 ee7d2a39-baff-4f07-ab05-86f09b5b05b2
11:12:59.991 index.html:36 a494dbc9-ce31-4892-acfa-c8b8b5a1420a
11:12:59.991 index.html:36 a3a02f90-4fdf-4f99-9f7d-8b7c559c43a5
11:12:59.991 index.html:36 d8213b47-a2ac-4914-8576-4a085fd664a4
11:12:59.992 index.html:36 0ac35fbd-48d2-436d-aa25-36ef5f386d32
11:12:59.992 index.html:36 23d550d2-b810-4fda-9ce7-212998c767e2
11:12:59.992 index.html:36 cee6eddb-7b02-401b-98dd-5f830f332f0e
11:12:59.992 index.html:36 34726101-f7b3-4c06-b289-fe28c37e00be
11:12:59.992 index.html:36 8c91ba72-bd67-4cdd-853a-f9ad3d4a4cba
11:12:59.992 index.html:36 96b2b3ce-779d-45c4-8762-570bee94d56b
11:12:59.992 index.html:36 83af6ef2-3c18-4952-800b-7c37b2fafa0b
11:12:59.992 index.html:36 36254638-00ec-4048-b46e-f5449316d4b8
11:12:59.992 index.html:36 2563b42e-abe4-4f10-967f-e2984474ef87
11:12:59.993 index.html:36 128e5c80-7ac3-42c3-b3ba-ccbea19e13a2
11:12:59.993 index.html:36 be4a2005-0e01-4eaf-9135-98737b40f0fd
11:12:59.993 index.html:36 04bafdcb-7d9a-48fc-835b-3a08eb508703
11:12:59.993 index.html:36 b57e53ac-2095-4270-b536-a3c8c1d46768
11:12:59.993 index.html:36 f6b3740c-119a-4e0c-88f0-2d3733555a0a
11:12:59.993 index.html:36 2551126d-9c3b-4b5f-8ece-e4a2ccd011d0
11:12:59.993 index.html:36 fd95d7f2-c9af-4d54-a7f9-9071faecb92e
11:12:59.993 index.html:36 a84de0cc-ffc6-48a6-9e10-200f8a51a621
11:12:59.993 index.html:36 3e359a2d-c3c7-4dd6-8af7-ae597e8787dc
11:12:59.993 index.html:36 488cf210-7b09-457c-ab5d-22b47c0cf9b6
11:12:59.993 index.html:36 67ffb2ab-5610-4fa2-b917-9b824e7a9f49
11:12:59.994 index.html:36 0fcca7ea-1a53-4adf-91f8-f9f69d6e5cfa
11:12:59.994 index.html:36 7c06bc3c-3c8f-4e2d-9ff9-2bfdf0308616
11:12:59.994 index.html:36 9d18b47c-1599-4103-8ef0-6dcab533798d
11:12:59.994 index.html:36 24199bc0-9caa-4101-9b9f-6701eabbcc23
11:12:59.994 index.html:36 d196ff7a-14f1-44b9-b7f8-8a609f0411aa
11:12:59.994 index.html:36 1e869d2b-8d31-48b4-aacc-9b3e20041627
11:12:59.994 index.html:36 b8b47527-ac52-4748-a588-403998938e9a
11:12:59.994 index.html:36 5b07d01c-fa96-48d9-b284-7463d1cb6152
11:12:59.994 index.html:36 67b16950-2a1e-45b9-9252-6d2c221c115d
11:12:59.994 index.html:36 1fac9902-bacd-4a3d-be91-2579858a0c61
11:12:59.994 index.html:36 7f07e573-3401-4243-a68d-4b9294eabe46
11:12:59.995 index.html:36 2e721de7-8550-40e6-8691-599af1040bbd
11:12:59.995 index.html:36 bdd5986d-9d37-4772-8a4d-54c85af3183d
11:12:59.995 index.html:36 cf0cbfbc-837e-45c3-9d38-d123d98078f9
11:12:59.995 index.html:36 23cf7970-3a60-44f5-8877-9c6b643473f4
11:12:59.995 index.html:36 868218a0-d7ce-4ea9-ba57-cb9831065844
11:12:59.995 index.html:36 70dae6ab-34a6-46fc-a09a-3b26892426be
11:12:59.995 index.html:36 47bb44ba-9304-4c84-b20a-586179144b91
11:12:59.995 index.html:36 8fb19bda-865b-438e-b4e1-1e43278f2677
11:12:59.995 index.html:36 018c9cdc-38df-4fa6-8d2e-bf69231dcf8c
11:12:59.995 index.html:36 231f18c0-c8cd-4f8a-b2e9-cc7a432d2bb3
11:12:59.995 index.html:36 af3a86fc-3713-4fd6-bc57-932256c63d13
11:12:59.996 index.html:36 a7c44812-a3cc-4614-9b4c-dff5d9ebc70f
11:12:59.996 index.html:36 d3fd1b47-ad6f-486c-b374-ca1995cef31f
11:12:59.996 index.html:36 191611d6-cd78-45a1-a271-3c67e9c121f4
11:12:59.996 index.html:36 99cd5285-1c0f-4e3e-bb83-a038c93050fd
11:12:59.996 index.html:36 6c2cc59b-e4a7-4507-ab4d-4c750f0be36d
11:12:59.996 index.html:36 1254ba32-7950-41d7-a781-c708048d4a8c
11:12:59.996 index.html:36 38d52bab-37e9-42c6-a70b-9b392d29afa9
11:12:59.996 index.html:36 f2caac05-346c-4bd7-933b-7d6fc006dc18
11:12:59.996 index.html:36 a4a99e87-7cc4-4652-a421-cdcd48cda88c
11:12:59.997 index.html:36 d72237d6-9ff0-4224-873e-aed702ed854c
11:12:59.997 index.html:36 255e4033-b713-4c33-9587-8ee1d7d64486
11:12:59.997 index.html:36 c0c4bc9c-3ced-46e4-87cf-ed08fd9907b8
11:12:59.997 index.html:36 76ee6ddb-9b5e-45fd-a195-2c11f1e83d05
11:12:59.997 index.html:36 44f33cc3-39bf-4ddf-b483-198339d68d84
11:12:59.997 index.html:36 3fe40e86-7754-4e2e-ab8b-127e9c9db92f
11:12:59.997 index.html:36 f23db3a3-d0c9-4c48-90dd-2b638ad9c93d
11:12:59.997 index.html:36 99c54bc3-02fb-481d-afe3-26ab8c2a00eb
11:12:59.997 index.html:36 c773a438-9a67-4325-9b20-245adef8c7a5
11:12:59.997 index.html:36 d685d3e2-1cd2-442f-967d-3a30ecb42179
11:12:59.998 index.html:36 8785d09a-e6a5-4500-9a01-5b6e172d6e11
11:12:59.998 index.html:36 e47fa5ab-66f7-4462-bb0e-e053eb2755eb
11:12:59.998 index.html:36 9139c83f-5aad-4b4b-b983-347ea4d2c64e
11:12:59.998 index.html:36 e01a890a-6941-4c80-96f5-28e2540cdec5
11:12:59.998 index.html:36 9cc8695d-7546-429a-96b9-d2e859ae5817
11:12:59.998 index.html:36 696ea299-071b-4277-835a-be7fba1ffeef
11:12:59.998 index.html:36 4df9e56d-305f-424e-b385-a343a0827d58
11:12:59.998 index.html:36 9e204980-794b-498b-89d8-c94e6b302e3f
11:12:59.998 index.html:36 0cf98295-1031-4a01-ba99-891abfe5cb18
11:12:59.998 index.html:36 43a23a9a-9f38-4a3d-9aa6-8dd2d2d211af
11:12:59.999 index.html:36 6dd7718a-21ed-40d1-a945-e8e4adbc1795
11:12:59.999 index.html:36 f631d80b-8449-4019-8dab-cd472ba506d0
11:12:59.999 index.html:36 d5293800-3b0c-4835-80c6-19407682e208
11:12:59.999 index.html:36 1e3d6c25-d4a3-4764-a2cb-cda91206e74b
11:12:59.999 index.html:36 e67ee2c3-f975-4883-910c-a70a9f3f1bda
11:12:59.999 index.html:36 c1adfc51-5852-471f-85cd-dd0d78f39f67
11:12:59.999 index.html:36 dbb5865a-d83a-4af9-a0b0-a028f36f60ac
11:12:59.999 index.html:36 382e7c23-5573-46ef-8428-5ef1850dd5a4
11:12:59.999 index.html:36 1c9c9891-308e-461e-80ef-9023c3eb7cf6
11:12:59.999 index.html:36 69f762d7-49ab-480e-9eaa-b0250305d796
11:12:59.999 index.html:36 a0e3e569-92d0-44b1-8c56-285821a828ee
11:13:00.000 index.html:36 cb36c9fe-7bfd-4416-b7bd-9cf35dd9f162
11:13:00.000 index.html:36 e8856a6b-52e4-4174-b1d3-e42183dd5172
11:13:00.000 index.html:36 6a8156fd-8d5b-457e-adeb-d85eb2a154eb
11:13:00.000 index.html:38 math 1000 end

@GLStephen GLStephen changed the title updates Fix for #2822 - Improve Uniqueness of UUID with Crypto API when Available Oct 9, 2018
snapwich
snapwich approved these changes Oct 12, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich added the needs 2nd review Core module updates require two approvals from the core team label Oct 12, 2018
@bretg bretg requested a review from mkendall07 October 25, 2018 20:27
mkendall07
mkendall07 approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvement!

@mkendall07 mkendall07 merged commit 5743e2b into prebid:master Oct 26, 2018
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Nov 2, 2018
@AlessandroDG
Rvr 2005 rvr analytics adapter (#4)
ba19ef6 
* Submitting EMX Digital Adapter (prebid#3173)

* Submitting EMX Digital Prebid Adapter

Submitting EMX Digital Prebid Adapter code

* fixing lint errors. updating our md

* updating to const/let variables. adding test spec.

* fixed linting on test spec js

* TheMediaGrid Bid Adapter (prebid#3204)

* Added Grid Bid Adapter

* remove priceType from TheMediaGrid Bid Adapter

* Adding user sync method for IFRAME and Pixel (prebid#3232)

* Submitting EMX Digital Prebid Adapter

Submitting EMX Digital Prebid Adapter code

* fixing lint errors. updating our md

* updating to const/let variables. adding test spec.

* fixed linting on test spec js

* adding emx usersync methods

* updates (prebid#3162)

* Only set native targeting if value exists. (prebid#3225)

* add nolint command line option, similar to notest (prebid#3234)

* add inskin iab vendor id: enables consent via string (prebid#3235)

* Added user sync support for undertone bid adapter (prebid#3172)

* Added user sync support for undertone bid adapter (new pull request)

* Added user sync support for undertone bid adapter

* fix indentation

* Changed utils.getWindowTop() with the newer prebid utilities

* Updating Auction Init Pick for timestamp + Test update (prebid#3223)

* Updating Auction Init Pick for timestamp + Test update

* Updating Auction Init to include  once again + Rubicon Analytics update accordingly

* Removing  from auction init events in favor of old

* Add code, test, and doc for Adikteev adapter (prebid#3229)

* Add code, test, and doc for Adikteev adapter

* Reflect comments on other PR

http://prebid.org/dev-docs/bidder-adaptor.html#referrers
prebid#3230 (comment)

* 'currency' isn't a bidder-specific param

Update PR following this remark on another one:
prebid#3228 (comment)

* Add integration example, fix bid requestId

* Quantcast adapter onTimeout (prebid#3239)

* onTimeout WIP

* test for onTimeout

* some renaming

* cleanup

* cleanup

* trying to fix the test

* using ajax instead of fetch

* Test cleanup (prebid#3238)

* stub pixel call in justpremium tests

* properly stub geolocation services to prevent prompts

* stub img creation as well to prevent call in justpremium

* Appnexus adapter: Added dealPriority and dealCode to bidResponse (prebid#3201)

* Added dealPriority and dealCode to appnexus adapter

* update failed test

* added namespace and did deep merge

* keep all properties together

* use unit id being sent instead of hard coded auid (prebid#3236)

* use unit id being sent instead of hard coded auid

* make multiple requests

* removes commented out code. adds aus param back

* Prebid 1.30.0 Release

* increment pre version

* fix deal targeting for cpm 0 (prebid#3233)

* YIELDONE adapter - support Video (prebid#3227)

* added UserSync

* added UserSync Unit Test

* support for multi sizes

* register the adapter as supporting video

* supporting video

* change requestId acquisition method

* fix the parameter name of dealID

* update test parameters

* support instream video

* add test for bidRequest

* add test for interpretResponse

* add test params

* add note to documentaion

* clarifying the multi-format support message

* rtbhouseBidAdapter changes (prebid#3241)

* Add transactionId support

* Change site getting method

* Add bidfloor param

* correct user agent value population (prebid#3248)

* RVR-1124 Setup initial skeleton analytics adapter that can send something.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Formatted auction/events data to fit needed schema.

* RVR-1135 fetched device data.

* Applied feedback.

* Applied feedback.

* Fetched core.

* Added click handler for reporting banners click events.

* Applied analyzer for reporting displayed impressions.

* Applied feedback.

* Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7)

RVR-1214 Invoke handlers on rendering

* RVR-1214 Invoked handlers right after ad is displayed.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1192-configuration-global-parameters (pull request #8)

RVR-1192 Configuration/Global parameters

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6)

RVR-1181 Prebid.js Unit tests setup

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1247-additional-data-to-impression-records (pull request #9)

RVR-1247 Additional data to impression records

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1249-add-requestedbids-to-auction (pull request #10)

RVR-1249 Add requested bids to auction object request.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1261-fix-tests (pull request prebid#11)

RVR-1261 fix tests

* RVR-1261 Secured adapter from no containers configuration. And changed fetching URL.

* RVR-1261 Added event check for request and changed some names.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* RVR-1352 analytics adapter bugs

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Fixed bug with geolocation notification.

* fixed missing bracket.

* one more fix.

* RVR-1357 Different optimisation responses & tracking into auction event

* RVR-1852 - Add content type and hardcoded auth headers

(cherry picked from commit 4def881)

* RVR-1852 - Change tracker host

* RVR-1852 - Override content type instead of adding header

* RVR-1914 Consistent data types in events

Also removes undefined and null properties in audience events

* Merged in RVR-1883-Add-Basic-Access-Authentication (pull request prebid#17)

RVR-1883 Add Basic Access Authentication

* RVR-1914 - Rename functions

* RVR-1914 - Set default total_duration to null in bid response

* RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token

* RVR-1883 - Restore stub after every test not just at the end

* RVR-1883 - Remove commented code

* Increase code coverage

* Fix for IE 11.0.0 and Safari 8.0.8 - includes()

Use core-js includes function for array

* Restore pbjs_api_spec.js

* Fix API calls for rivr analytics impressions and clicks

* RVR-2005 - Change auction object model

* RVR-2005 - Set rvr_usr_id cookie

* RVR-2005 - Remove BID_REQUESTED and BID_RESPONSE handlers

We have the same infos all collected in AUCTION_END

* RVR-2005 - build Bidders Array From Auction End

* RVR-2005 - build impressions Array From Auction End

* RVR-2005 - set status of winning bid

* RVR-2005 - cleanup

* RVR-2005 - adapt enableAnalytics() test

* RVR-2005 - adapt all tests

* RVR-2005 - Add Rivr Analytics adapter md file

* RVR-2005 - rewrite connectAllUnits

* RVR-2005 - correct typo

* RVR-2005 - use IE compatible find()
jsnellbaker pushed a commit that referenced this pull request Nov 5, 2018
@jsnellbaker
Rivr Analytics Adapter (#3202)
432c656 
* RVR-1124 Setup initial skeleton analytics adapter that can send something.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Formatted auction/events data to fit needed schema.

* RVR-1135 fetched device data.

* Applied feedback.

* Applied feedback.

* Fetched core.

* Added click handler for reporting banners click events.

* Applied analyzer for reporting displayed impressions.

* Applied feedback.

* Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7)

RVR-1214 Invoke handlers on rendering

* RVR-1214 Invoked handlers right after ad is displayed.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1192-configuration-global-parameters (pull request #8)

RVR-1192 Configuration/Global parameters

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6)

RVR-1181 Prebid.js Unit tests setup

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1247-additional-data-to-impression-records (pull request #9)

RVR-1247 Additional data to impression records

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1249-add-requestedbids-to-auction (pull request #10)

RVR-1249 Add requested bids to auction object request.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1261-fix-tests (pull request #11)

RVR-1261 fix tests

* RVR-1261 Secured adapter from no containers configuration. And changed fetching URL.

* RVR-1261 Added event check for request and changed some names.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* RVR-1352 analytics adapter bugs

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Fixed bug with geolocation notification.

* fixed missing bracket.

* one more fix.

* RVR-1357 Different optimisation responses & tracking into auction event

* RVR-1852 - Add content type and hardcoded auth headers

(cherry picked from commit 4def881)

* RVR-1852 - Change tracker host

* RVR-1852 - Override content type instead of adding header

* RVR-1914 Consistent data types in events

Also removes undefined and null properties in audience events

* Merged in RVR-1883-Add-Basic-Access-Authentication (pull request #17)

RVR-1883 Add Basic Access Authentication

* RVR-1914 - Rename functions

* RVR-1914 - Set default total_duration to null in bid response

* RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token

* RVR-1883 - Restore stub after every test not just at the end

* RVR-1883 - Remove commented code

* Increase code coverage

* Fix for IE 11.0.0 and Safari 8.0.8 - includes()

Use core-js includes function for array

* Restore pbjs_api_spec.js

* Fix API calls for rivr analytics impressions and clicks

* Rvr 2005 rvr analytics adapter (#4)

* Submitting EMX Digital Adapter (#3173)

* Submitting EMX Digital Prebid Adapter

Submitting EMX Digital Prebid Adapter code

* fixing lint errors. updating our md

* updating to const/let variables. adding test spec.

* fixed linting on test spec js

* TheMediaGrid Bid Adapter (#3204)

* Added Grid Bid Adapter

* remove priceType from TheMediaGrid Bid Adapter

* Adding user sync method for IFRAME and Pixel (#3232)

* Submitting EMX Digital Prebid Adapter

Submitting EMX Digital Prebid Adapter code

* fixing lint errors. updating our md

* updating to const/let variables. adding test spec.

* fixed linting on test spec js

* adding emx usersync methods

* updates (#3162)

* Only set native targeting if value exists. (#3225)

* add nolint command line option, similar to notest (#3234)

* add inskin iab vendor id: enables consent via string (#3235)

* Added user sync support for undertone bid adapter (#3172)

* Added user sync support for undertone bid adapter (new pull request)

* Added user sync support for undertone bid adapter

* fix indentation

* Changed utils.getWindowTop() with the newer prebid utilities

* Updating Auction Init Pick for timestamp + Test update (#3223)

* Updating Auction Init Pick for timestamp + Test update

* Updating Auction Init to include  once again + Rubicon Analytics update accordingly

* Removing  from auction init events in favor of old

* Add code, test, and doc for Adikteev adapter (#3229)

* Add code, test, and doc for Adikteev adapter

* Reflect comments on other PR

http://prebid.org/dev-docs/bidder-adaptor.html#referrers
#3230 (comment)

* 'currency' isn't a bidder-specific param

Update PR following this remark on another one:
#3228 (comment)

* Add integration example, fix bid requestId

* Quantcast adapter onTimeout (#3239)

* onTimeout WIP

* test for onTimeout

* some renaming

* cleanup

* cleanup

* trying to fix the test

* using ajax instead of fetch

* Test cleanup (#3238)

* stub pixel call in justpremium tests

* properly stub geolocation services to prevent prompts

* stub img creation as well to prevent call in justpremium

* Appnexus adapter: Added dealPriority and dealCode to bidResponse (#3201)

* Added dealPriority and dealCode to appnexus adapter

* update failed test

* added namespace and did deep merge

* keep all properties together

* use unit id being sent instead of hard coded auid (#3236)

* use unit id being sent instead of hard coded auid

* make multiple requests

* removes commented out code. adds aus param back

* Prebid 1.30.0 Release

* increment pre version

* fix deal targeting for cpm 0 (#3233)

* YIELDONE adapter - support Video (#3227)

* added UserSync

* added UserSync Unit Test

* support for multi sizes

* register the adapter as supporting video

* supporting video

* change requestId acquisition method

* fix the parameter name of dealID

* update test parameters

* support instream video

* add test for bidRequest

* add test for interpretResponse

* add test params

* add note to documentaion

* clarifying the multi-format support message

* rtbhouseBidAdapter changes (#3241)

* Add transactionId support

* Change site getting method

* Add bidfloor param

* correct user agent value population (#3248)

* RVR-1124 Setup initial skeleton analytics adapter that can send something.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Formatted auction/events data to fit needed schema.

* RVR-1135 fetched device data.

* Applied feedback.

* Applied feedback.

* Fetched core.

* Added click handler for reporting banners click events.

* Applied analyzer for reporting displayed impressions.

* Applied feedback.

* Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7)

RVR-1214 Invoke handlers on rendering

* RVR-1214 Invoked handlers right after ad is displayed.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1192-configuration-global-parameters (pull request #8)

RVR-1192 Configuration/Global parameters

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6)

RVR-1181 Prebid.js Unit tests setup

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1247-additional-data-to-impression-records (pull request #9)

RVR-1247 Additional data to impression records

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1249-add-requestedbids-to-auction (pull request #10)

RVR-1249 Add requested bids to auction object request.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1261-fix-tests (pull request #11)

RVR-1261 fix tests

* RVR-1261 Secured adapter from no containers configuration. And changed fetching URL.

* RVR-1261 Added event check for request and changed some names.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* RVR-1352 analytics adapter bugs

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Fixed bug with geolocation notification.

* fixed missing bracket.

* one more fix.

* RVR-1357 Different optimisation responses & tracking into auction event

* RVR-1852 - Add content type and hardcoded auth headers

(cherry picked from commit 4def881)

* RVR-1852 - Change tracker host

* RVR-1852 - Override content type instead of adding header

* RVR-1914 Consistent data types in events

Also removes undefined and null properties in audience events

* Merged in RVR-1883-Add-Basic-Access-Authentication (pull request #17)

RVR-1883 Add Basic Access Authentication

* RVR-1914 - Rename functions

* RVR-1914 - Set default total_duration to null in bid response

* RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token

* RVR-1883 - Restore stub after every test not just at the end

* RVR-1883 - Remove commented code

* Increase code coverage

* Fix for IE 11.0.0 and Safari 8.0.8 - includes()

Use core-js includes function for array

* Restore pbjs_api_spec.js

* Fix API calls for rivr analytics impressions and clicks

* RVR-2005 - Change auction object model

* RVR-2005 - Set rvr_usr_id cookie

* RVR-2005 - Remove BID_REQUESTED and BID_RESPONSE handlers

We have the same infos all collected in AUCTION_END

* RVR-2005 - build Bidders Array From Auction End

* RVR-2005 - build impressions Array From Auction End

* RVR-2005 - set status of winning bid

* RVR-2005 - cleanup

* RVR-2005 - adapt enableAnalytics() test

* RVR-2005 - adapt all tests

* RVR-2005 - Add Rivr Analytics adapter md file

* RVR-2005 - rewrite connectAllUnits

* RVR-2005 - correct typo

* RVR-2005 - use IE compatible find()
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
@GLStephen
updates (prebid#3162)
8c10dcf
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
Rivr Analytics Adapter (prebid#3202)
b66af49 
* RVR-1124 Setup initial skeleton analytics adapter that can send something.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Formatted auction/events data to fit needed schema.

* RVR-1135 fetched device data.

* Applied feedback.

* Applied feedback.

* Fetched core.

* Added click handler for reporting banners click events.

* Applied analyzer for reporting displayed impressions.

* Applied feedback.

* Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7)

RVR-1214 Invoke handlers on rendering

* RVR-1214 Invoked handlers right after ad is displayed.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1192-configuration-global-parameters (pull request #8)

RVR-1192 Configuration/Global parameters

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6)

RVR-1181 Prebid.js Unit tests setup

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1247-additional-data-to-impression-records (pull request #9)

RVR-1247 Additional data to impression records

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1249-add-requestedbids-to-auction (pull request #10)

RVR-1249 Add requested bids to auction object request.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1261-fix-tests (pull request #11)

RVR-1261 fix tests

* RVR-1261 Secured adapter from no containers configuration. And changed fetching URL.

* RVR-1261 Added event check for request and changed some names.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* RVR-1352 analytics adapter bugs

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Fixed bug with geolocation notification.

* fixed missing bracket.

* one more fix.

* RVR-1357 Different optimisation responses & tracking into auction event

* RVR-1852 - Add content type and hardcoded auth headers

(cherry picked from commit 4def881)

* RVR-1852 - Change tracker host

* RVR-1852 - Override content type instead of adding header

* RVR-1914 Consistent data types in events

Also removes undefined and null properties in audience events

* Merged in RVR-1883-Add-Basic-Access-Authentication (pull request #17)

RVR-1883 Add Basic Access Authentication

* RVR-1914 - Rename functions

* RVR-1914 - Set default total_duration to null in bid response

* RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token

* RVR-1883 - Restore stub after every test not just at the end

* RVR-1883 - Remove commented code

* Increase code coverage

* Fix for IE 11.0.0 and Safari 8.0.8 - includes()

Use core-js includes function for array

* Restore pbjs_api_spec.js

* Fix API calls for rivr analytics impressions and clicks

* Rvr 2005 rvr analytics adapter (#4)

* Submitting EMX Digital Adapter (prebid#3173)

* Submitting EMX Digital Prebid Adapter

Submitting EMX Digital Prebid Adapter code

* fixing lint errors. updating our md

* updating to const/let variables. adding test spec.

* fixed linting on test spec js

* TheMediaGrid Bid Adapter (prebid#3204)

* Added Grid Bid Adapter

* remove priceType from TheMediaGrid Bid Adapter

* Adding user sync method for IFRAME and Pixel (prebid#3232)

* Submitting EMX Digital Prebid Adapter

Submitting EMX Digital Prebid Adapter code

* fixing lint errors. updating our md

* updating to const/let variables. adding test spec.

* fixed linting on test spec js

* adding emx usersync methods

* updates (prebid#3162)

* Only set native targeting if value exists. (prebid#3225)

* add nolint command line option, similar to notest (prebid#3234)

* add inskin iab vendor id: enables consent via string (prebid#3235)

* Added user sync support for undertone bid adapter (prebid#3172)

* Added user sync support for undertone bid adapter (new pull request)

* Added user sync support for undertone bid adapter

* fix indentation

* Changed utils.getWindowTop() with the newer prebid utilities

* Updating Auction Init Pick for timestamp + Test update (prebid#3223)

* Updating Auction Init Pick for timestamp + Test update

* Updating Auction Init to include  once again + Rubicon Analytics update accordingly

* Removing  from auction init events in favor of old

* Add code, test, and doc for Adikteev adapter (prebid#3229)

* Add code, test, and doc for Adikteev adapter

* Reflect comments on other PR

http://prebid.org/dev-docs/bidder-adaptor.html#referrers
prebid#3230 (comment)

* 'currency' isn't a bidder-specific param

Update PR following this remark on another one:
prebid#3228 (comment)

* Add integration example, fix bid requestId

* Quantcast adapter onTimeout (prebid#3239)

* onTimeout WIP

* test for onTimeout

* some renaming

* cleanup

* cleanup

* trying to fix the test

* using ajax instead of fetch

* Test cleanup (prebid#3238)

* stub pixel call in justpremium tests

* properly stub geolocation services to prevent prompts

* stub img creation as well to prevent call in justpremium

* Appnexus adapter: Added dealPriority and dealCode to bidResponse (prebid#3201)

* Added dealPriority and dealCode to appnexus adapter

* update failed test

* added namespace and did deep merge

* keep all properties together

* use unit id being sent instead of hard coded auid (prebid#3236)

* use unit id being sent instead of hard coded auid

* make multiple requests

* removes commented out code. adds aus param back

* Prebid 1.30.0 Release

* increment pre version

* fix deal targeting for cpm 0 (prebid#3233)

* YIELDONE adapter - support Video (prebid#3227)

* added UserSync

* added UserSync Unit Test

* support for multi sizes

* register the adapter as supporting video

* supporting video

* change requestId acquisition method

* fix the parameter name of dealID

* update test parameters

* support instream video

* add test for bidRequest

* add test for interpretResponse

* add test params

* add note to documentaion

* clarifying the multi-format support message

* rtbhouseBidAdapter changes (prebid#3241)

* Add transactionId support

* Change site getting method

* Add bidfloor param

* correct user agent value population (prebid#3248)

* RVR-1124 Setup initial skeleton analytics adapter that can send something.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Formatted auction/events data to fit needed schema.

* RVR-1135 fetched device data.

* Applied feedback.

* Applied feedback.

* Fetched core.

* Added click handler for reporting banners click events.

* Applied analyzer for reporting displayed impressions.

* Applied feedback.

* Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7)

RVR-1214 Invoke handlers on rendering

* RVR-1214 Invoked handlers right after ad is displayed.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1192-configuration-global-parameters (pull request #8)

RVR-1192 Configuration/Global parameters

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6)

RVR-1181 Prebid.js Unit tests setup

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1247-additional-data-to-impression-records (pull request #9)

RVR-1247 Additional data to impression records

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1249-add-requestedbids-to-auction (pull request #10)

RVR-1249 Add requested bids to auction object request.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1261-fix-tests (pull request #11)

RVR-1261 fix tests

* RVR-1261 Secured adapter from no containers configuration. And changed fetching URL.

* RVR-1261 Added event check for request and changed some names.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* RVR-1352 analytics adapter bugs

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Fixed bug with geolocation notification.

* fixed missing bracket.

* one more fix.

* RVR-1357 Different optimisation responses & tracking into auction event

* RVR-1852 - Add content type and hardcoded auth headers

(cherry picked from commit 4def881)

* RVR-1852 - Change tracker host

* RVR-1852 - Override content type instead of adding header

* RVR-1914 Consistent data types in events

Also removes undefined and null properties in audience events

* Merged in RVR-1883-Add-Basic-Access-Authentication (pull request #17)

RVR-1883 Add Basic Access Authentication

* RVR-1914 - Rename functions

* RVR-1914 - Set default total_duration to null in bid response

* RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token

* RVR-1883 - Restore stub after every test not just at the end

* RVR-1883 - Remove commented code

* Increase code coverage

* Fix for IE 11.0.0 and Safari 8.0.8 - includes()

Use core-js includes function for array

* Restore pbjs_api_spec.js

* Fix API calls for rivr analytics impressions and clicks

* RVR-2005 - Change auction object model

* RVR-2005 - Set rvr_usr_id cookie

* RVR-2005 - Remove BID_REQUESTED and BID_RESPONSE handlers

We have the same infos all collected in AUCTION_END

* RVR-2005 - build Bidders Array From Auction End

* RVR-2005 - build impressions Array From Auction End

* RVR-2005 - set status of winning bid

* RVR-2005 - cleanup

* RVR-2005 - adapt enableAnalytics() test

* RVR-2005 - adapt all tests

* RVR-2005 - Add Rivr Analytics adapter md file

* RVR-2005 - rewrite connectAllUnits

* RVR-2005 - correct typo

* RVR-2005 - use IE compatible find()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

@snapwich snapwich snapwich approved these changes

Assignees

@mkendall07 mkendall07

Labels
needs review needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GLStephen @snapwich @mkendall07 @bwoolcott