Add a check against the size config when setting targeting #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,6 +199,7 @@ export function newTargeting(auctionManager) { | |||
|
|
|||
| function getBidsReceived() { | |||
| const bidsReceived = auctionManager.getBidsReceived() | |||
| .filter(bid => bid.mediaType !== 'banner' || sizeSupported([bid.width, bid.height])) | |||
There was a problem hiding this comment.
What is the reason for this bid.mediaType !== 'banner' here ?
There was a problem hiding this comment.
size mapping only applies to (and filters) banner ads currently, so if it is not a banner bid then the filter will immediately let it through and not apply any size filtering.
jsnellbaker
approved these changes
Oct 17, 2018
jsnellbaker
added
the
needs 2nd review
jaiminpanchal27
approved these changes
Oct 17, 2018
idettman
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Nov 14, 2018
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add an extra check for size configs when setting targeting so that a cached bid that was valid cannot be used if it has become invalid by the screen changing size since last auction.
Other information
fixes #2861