add stub for adloader.loadScript in various adapter test files #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
approved these changes
Oct 17, 2018
|
LGTM |
idettman
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Nov 14, 2018
…d#3193) * add stub for adloader in various adapter test files * remove unneeded commented line of code
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…d#3193) * add stub for adloader in various adapter test files * remove unneeded commented line of code
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
…d#3193) * add stub for adloader in various adapter test files * remove unneeded commented line of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR adds a stub for the
adloder.loadScriptfunction in various adapters' spec files that test theRendererobject.Previously, there were a series of sporadic errors/warnings when running browserstack tests due to the
loadScriptfunction attempting to load valid/faked values for the renderer source url. #3187 is one example of the errors that were causing unit test failures.With the stubs in place, these requests will be properly handled and greatly reduce the spam in the browserstack test's console output.