Stub adloader across the board to prevent requests going out #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
approved these changes
Oct 17, 2018
|
That is the goal as mentioned in the description #2779 by @jsnellbaker. Jason did some cleanup. |
|
@mkendall07 I'm not sure on the status of adloader.js as a whole, however it only exports two functions ( |
|
alright well the work is already done here so I'm good with merging. Eventually we should delete it. Thanks! |
idettman
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Nov 14, 2018
…3196) * stub adloader across the board to prevent requests going out * add the adloader stub
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…3196) * stub adloader across the board to prevent requests going out * add the adloader stub
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
…3196) * stub adloader across the board to prevent requests going out * add the adloader stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Pulled out the adloader stubbing into a global mock so that it is stubbed by default. Modules that need to use the actual adloader implementation (like adloader_spec.js) can access the original through the mock module.