Add buyer bid adapter #3200
Merged
Add buyer bid adapter #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
requested changes
Oct 18, 2018
There was a problem hiding this comment.
@avj83 Thanks for putting this adapter together.
It largely looks good and the test param you included in the description is successfully returning the bid. There are a few points that should be reviewed (see in-line comments).
modules/buyerBidAdapter.js
Outdated
| const placementId = params.placement; | ||
|
|
||
| const rnd = Math.floor(Math.random() * 99999999999); | ||
| const referrer = encodeURIComponent(utils.getTopWindowUrl()); // bidderRequest.refererInfo ?? |
There was a problem hiding this comment.
I would suggest to use the bidderRequest.referrerInfo.referer field instead of the utils.getTopWindowUrl() as that will eventually be deprecated.
modules/buyerBidAdapter.js
Outdated
| } | ||
| return bidResponses; | ||
| }, | ||
| getUserSyncs: function(syncOptions, serverResponses) { |
There was a problem hiding this comment.
If you're not going to set any pixels, you can remove this entire getUserSyncs property from the adapter code.
|
Also - to clear the circleci errors, please resync/rebase off of |
jsnellbaker
approved these changes
Oct 19, 2018
|
Thanks for making the updates; LGTM |
idettman
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Nov 14, 2018
* add adapter and doc * add test * fix adapter * fix adapter * fix adapter * correct code after tests * fix tests * fix adapter and test * fix buildQueryString and tests * fix cpm devisor * fix cpm devisor test * fix doc * fix tests * add adapter and doc * add test * fix adapter * fix adapter * fix adapter * correct code after tests * fix tests * fix adapter and test * fix buildQueryString and tests * fix cpm devisor * fix cpm devisor test * fix doc * fix tests * change referer source and remove userSync
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* add adapter and doc * add test * fix adapter * fix adapter * fix adapter * correct code after tests * fix tests * fix adapter and test * fix buildQueryString and tests * fix cpm devisor * fix cpm devisor test * fix doc * fix tests * add adapter and doc * add test * fix adapter * fix adapter * fix adapter * correct code after tests * fix tests * fix adapter and test * fix buildQueryString and tests * fix cpm devisor * fix cpm devisor test * fix doc * fix tests * change referer source and remove userSync
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* add adapter and doc * add test * fix adapter * fix adapter * fix adapter * correct code after tests * fix tests * fix adapter and test * fix buildQueryString and tests * fix cpm devisor * fix cpm devisor test * fix doc * fix tests * add adapter and doc * add test * fix adapter * fix adapter * fix adapter * correct code after tests * fix tests * fix adapter and test * fix buildQueryString and tests * fix cpm devisor * fix cpm devisor test * fix doc * fix tests * change referer source and remove userSync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New adapter
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information