Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubicon adapter: Removed extraneous warning #3218

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Rubicon adapter: Removed extraneous warning #3218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
835ed13
Rubicon adapter: Removed extraneous warning
bretg Oct 23, 2018
ab1d23b
removing spaces to kick off the build again
bretg Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions modules/rubiconBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,9 @@ export const spec = {
if (typeof bid.params !== 'object') {
return false;
}

if (!/^\d+$/.test(bid.params.accountId)) {
return false;
}

return !!bidType(bid, true);
},
/**
Expand Down Expand Up @@ -581,7 +579,6 @@ function mapSizes(sizes) {
*/
export function hasVideoMediaType(bidRequest) {
if (typeof utils.deepAccess(bidRequest, 'params.video') === 'undefined' && Array.isArray(utils.deepAccess(bidRequest, 'params.sizes'))) {
utils.logWarn('Rubicon bid adapter Warning: no video params found, convert to banner with the bidder size id');
return false;
}
return (bidRequest.mediaType === VIDEO || typeof utils.deepAccess(bidRequest, `mediaTypes.${VIDEO}`) !== 'undefined');
Expand Down