Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidfluence adapter 1.x #3244

Merged
merged 7 commits into from
Nov 5, 2018
Merged

Bidfluence adapter 1.x #3244

merged 7 commits into from
Nov 5, 2018

Conversation

francescocristallo
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'bidfluence',
  params: {
        placementId: '1000',
        publisherId: '1000'
  }
}

Copy link
Contributor Author

@francescocristallo francescocristallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fixed

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francescocristallo Thanks for submitting this adapter.

Can you please take a look at the in-line item below?

In addition, when I tried to test the adapter using a test page that had the consentManagement module setup, I observed the outgoing request to the server returned a 400 Bad Request.

The only response from the server was "Data null".

Below is a copy of the request payload, do you see anything misconfigured? If not, can you please take a look on your end to see what might be the issue?

{"bid":"2981aae6597b6d","v":"1.0","azr":true,"ck":true,"tid":"1000","pid":"1000","rp":0,"re":"http://ap.localhost:9999/integrationExamples/gpt/gdpr_hello_world.html?pbjs_debug=true","st":["http://ap.localhost:9999/integrationExamples/gpt/gdpr_hello_world.html?pbjs_debug=true"],"tz":"300","sr":"1680x1050x24","tm":3000,"vp":"1682x293","sdt":"2018/10/31 18:22:07","w":"300","h":"250","gdpr":true,"gdprc":"BOQ1nE8OWg3wLABABAENBz-AAAAiB7_______9______9uz_Gv_v_f__33e8__9v_l_7_-___u_-33d4-_1vX99yfm1-7ftr1tp386ues2LDiCAAAAAAAAAA","gdprvd":{"metadata":"BOQ1nE8OWg3wLABABAENBzA","gdprApplies":true,"hasGlobalScope":false,"cookieVersion":1,"created":"2018-07-13T13:11:08.400Z","lastUpdated":"2018-10-31T18:22:05.900Z","cmpId":1,"cmpVersion":1,"consentScreen":0,"consentLanguage":"EN","vendorListVersion":115,"maxVendorId":544,"purposeConsents":{"1":true,"2":true,"3":true,"4":true,"5":true},"vendorConsents":{"1":true,"2":true,"3":true,"4":true,"5":false,"6":true,"7":true,"8":true,"9":true,"10":true,"11":true,"12":true,"13":true,"14":true,"15":true,"16":true,"17":true,"18":true,"19":true,"20":true,"21":true,"22":true,"23":true,"24":true,"25":true,"26":true,"27":true,"28":true,"29":true,"30":true,"31":true,"32":true,"33":true,"34":true,"35":true,"36":true,"37":true,"38":true,"39":true,"40":true,"41":true,"42":true,"43":true,"44":true,"45":true,"46":true,"47":true,"48":true,"49":true,"50":true,"51":true,"52":true,"53":true,"54":false,"55":true,"56":true,"57":true,"58":true,"59":true,"60":true,"61":true,"62":true,"63":true,"64":true,"65":true,"66":true,"67":true,"68":true,"69":true,"70":true,"71":true,"72":true,"73":true,"74":true,"75":true,"76":true,"77":true,"78":true,"79":true,"80":true,"81":true,"82":true,"83":true,"84":true,"85":true,"86":true,"87":true,"88":true,"89":true,"90":true,"91":true,"92":true,"93":true,"94":true,"95":true,"96":false,"97":true,"98":true,"99":false,"100":true,"101":true,"102":true,"103":false,"104":true,"105":true,"106":false,"107":false,"108":true,"109":true,"110":true,"111":true,"112":true,"113":true,"114":true,"115":true,"116":false,"117":false,"118":false,"119":true,"120":true,"121":false,"122":true,"123":false,"124":true,"125":true,"126":true,"127":true,"128":true,"129":true,"130":true,"131":true,"132":true,"133":true,"134":true,"135":false,"136":true,"137":true,"138":true,"139":true,"140":true,"141":true,"142":true,"143":true,"144":true,"145":true,"146":false,"147":true,"148":true,"149":true,"150":true,"151":true,"152":true,"153":true,"154":true,"155":true,"156":true,"157":true,"158":true,"159":true,"160":true,"161":true,"162":true,"163":true,"164":true,"165":true,"166":false,"167":true,"168":true,"169":true,"170":true,"171":true,"172":false,"173":true,"174":true,"175":true,"176":false,"177":true,"178":true,"179":true,"180":true,"181":false,"182":true,"183":true,"184":true,"185":true,"186":false,"187":false,"188":true,"189":true,"190":true,"191":true,"192":true,"193":true,"194":true,"195":true,"196":true,"197":true,"198":true,"199":true,"200":true,"201":true,"202":true,"203":true,"204":false,"205":true,"206":true,"207":false,"208":true,"209":true,"210":true,"211":true,"212":true,"213":true,"214":true,"215":true,"216":true,"217":true,"218":true,"219":false,"220":false,"221":true,"222":false,"223":true,"224":true,"225":true,"226":true,"227":true,"228":true,"229":true,"230":true,"231":true,"232":true,"233":false,"234":true,"235":true,"236":true,"237":true,"238":true,"239":true,"240":true,"241":true,"242":true,"243":true,"244":true,"245":true,"246":true,"247":false,"248":true,"249":true,"250":true,"251":true,"252":true,"253":true,"254":true,"255":true,"256":true,"257":true,"258":true,"259":true,"260":true,"261":true,"262":true,"263":true,"264":true,"265":true,"266":true,"267":false,"268":true,"269":true,"270":true,"271":false,"272":true,"273":true,"274":true,"275":true,"276":true,"277":true,"278":true,"279":true,"280":true,"281":true,"282":true,"283":false,"284":true,"285":true,"286":false,"287":true,"288":true,"289":true,"290":true,"291":true,"292":false,"293":true,"294":true,"295":true,"296":false,"297":true,"298":true,"299":true,"300":false,"301":true,"302":true,"303":true,"304":true,"305":false,"306":false,"307":false,"308":true,"309":true,"310":true,"311":true,"312":true,"313":false,"314":true,"315":true,"316":true,"317":true,"318":true,"319":true,"320":true,"321":true,"322":false,"323":true,"324":false,"325":true,"326":true,"327":false,"328":true,"329":true,"330":true,"331":true,"332":false,"333":true,"334":false,"335":true,"336":true,"337":true,"338":true,"339":true,"340":true,"341":true,"342":false,"343":true,"344":true,"345":true,"346":true,"347":true,"348":false,"349":true,"350":true,"351":true,"352":false,"353":false,"354":true,"355":false,"356":false,"357":true,"358":true,"359":true,"360":true,"361":true,"362":true,"363":false,"364":false,"365":true,"366":true,"367":false,"368":true,"369":true,"370":false,"371":true,"372":false,"373":true,"374":true,"375":true,"376":true,"377":true,"378":true,"379":false,"380":true,"381":true,"382":true,"383":false,"384":true,"385":true,"386":false,"387":true,"388":true,"389":true,"390":true,"391":true,"392":true,"393":false,"394":true,"395":true,"396":false,"397":true,"398":true,"399":false,"400":true,"401":false,"402":true,"403":true,"404":true,"405":true,"406":false,"407":true,"408":false,"409":true,"410":true,"411":false,"412":true,"413":true,"414":false,"415":true,"416":true,"417":false,"418":true,"419":false,"420":false,"421":true,"422":true,"423":true,"424":false,"425":true,"426":true,"427":true,"428":true,"429":true,"430":true,"431":true,"432":false,"433":false,"434":true,"435":true,"436":true,"437":false,"438":true,"439":false,"440":true,"441":false,"442":true,"443":true,"444":true,"445":false,"446":false,"447":true,"448":true,"449":true,"450":true,"451":false,"452":true,"453":false,"454":true,"455":true,"456":false,"457":false,"458":true,"459":true,"460":false,"461":true,"462":true,"463":false,"464":false,"465":false,"466":true,"467":false,"468":true,"469":true,"470":false,"471":false,"472":false,"473":false,"474":true,"475":true,"476":true,"477":false,"478":false,"479":false,"480":true,"481":false,"482":false,"483":false,"484":false,"485":false,"486":true,"487":false,"488":false,"489":false,"490":false,"491":false,"492":false,"493":false,"494":false,"495":false,"496":false,"497":false,"498":false,"499":false,"500":false,"501":false,"502":false,"503":false,"504":false,"505":false,"506":false,"507":false,"508":false,"509":false,"510":false,"511":false,"512":false,"513":false,"514":false,"515":false,"516":false,"517":false,"518":false,"519":false,"520":false,"521":false,"522":false,"523":false,"524":false,"525":false,"526":false,"527":false,"528":false,"529":false,"530":false,"531":false,"532":false,"533":false,"534":false,"535":false,"536":false,"537":false,"538":false,"539":false,"540":false,"541":false,"542":false,"543":false,"544":false}}}

modules/bidfluenceBidAdapter.js Outdated Show resolved Hide resolved
Copy link
Contributor Author

@francescocristallo francescocristallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing it so quickly. I fixed the gdpr undefined object in case the module is not installed, and removed the gdpr vendor object that was not supported our side causing the BadRequest.
I tested with and without gdpr installed using a real implementation and it works, let me know if other updates are needed. Thanks!

Copy link
Contributor Author

@francescocristallo francescocristallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated .md page as requested here:
prebid/prebid.github.io#1020 (comment)

@jsnellbaker jsnellbaker merged commit 5e1c996 into prebid:master Nov 5, 2018
@francescocristallo francescocristallo deleted the bidfluence-adapter branch November 5, 2018 18:56
idettman pushed a commit to rubicon-project/Prebid.js that referenced this pull request Nov 14, 2018
* Bidfluence Adapter 1.x

* Test for Bidfluence Adapter 1.x

* Update to Bidfluence Adapter 1.x

* Update due to test not passing

* Fixed undefined gdpr object and unsupported gdpr vendor

* Removed gdpr vendor line test

* Updated as requested 

Related to prebid/prebid.github.io#1020 (comment)
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* Bidfluence Adapter 1.x

* Test for Bidfluence Adapter 1.x

* Update to Bidfluence Adapter 1.x

* Update due to test not passing

* Fixed undefined gdpr object and unsupported gdpr vendor

* Removed gdpr vendor line test

* Updated as requested 

Related to prebid/prebid.github.io#1020 (comment)
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
* Bidfluence Adapter 1.x

* Test for Bidfluence Adapter 1.x

* Update to Bidfluence Adapter 1.x

* Update due to test not passing

* Fixed undefined gdpr object and unsupported gdpr vendor

* Removed gdpr vendor line test

* Updated as requested 

Related to prebid/prebid.github.io#1020 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants