Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextMilleniumBidAdapter #3249

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Add nextMilleniumBidAdapter #3249

merged 2 commits into from
Nov 12, 2018

Conversation

mifanich
Copy link
Contributor

@mifanich mifanich commented Nov 1, 2018

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

  • test parameters for validating bids

{
    bidder: 'nextMillenium',
    params: {
        placement_id: -1
    }
}

Be sure to test the integration with your adserver using the Hello World sample page.

@jsnellbaker jsnellbaker self-requested a review November 2, 2018 14:36
@jsnellbaker jsnellbaker self-assigned this Nov 2, 2018
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mifanich Thanks for submitting this new adapter.

While I was testing the adapters with the noted bidder params, I was seeing a {"success":false,"error":"bad request"} as the response from the server. Below is a copy of the payload that was used for the POST request:

{"placement_id":-1}

Can you take a look to see why the test bid params were not working?

Additionally, could you update the unit tests to include a check on the buildRequest function (this would improve the code coverage % for the adapter, which is only at ~74% currently)?

@mifanich
Copy link
Contributor Author

mifanich commented Nov 8, 2018

@jsnellbaker Hello. Thanks for fast review. I've made fixes. Now the test ad is displayed.

@jsnellbaker jsnellbaker merged commit 1b5b83e into prebid:master Nov 12, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* Add nextMilleniumBidAdapter

* fix bugs
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
* Add nextMilleniumBidAdapter

* fix bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants