Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi currency #3250

Merged
merged 10 commits into from
Nov 6, 2018
Merged

Multi currency #3250

merged 10 commits into from
Nov 6, 2018

Conversation

teranchristian
Copy link
Contributor

Type of change

  • Bugfix
  • [ x] Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

add support to multiples currencies

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • [ x] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@teranchristian
Copy link
Contributor Author

teranchristian commented Nov 2, 2018 •
edited
Loading

NOTE: we pushed this originally without the package-lock.json and many testes were failing. After we pushed the package-lock.json all the checks passed

@jsnellbaker jsnellbaker requested a review from idettman November 2, 2018 14:37
idettman
idettman approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to investigate why the tests fail if the package-lock.json isn't included

idettman
idettman reviewed Nov 2, 2018
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the package-lock file? I'd like to investigate the cause of the test errors.

idettman
idettman suggested changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove package-lock file

@teranchristian
Copy link
Contributor Author

@idettman I remove the package-lock as requested

idettman
idettman approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit 3b541a3 into prebid:master Nov 6, 2018
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
@teranchristian
Multi currency (prebid#3250)
48cf3e7 
* corrected user sync type

* add support to multiple currencies

* push package-lock

* remove package lock

* restore packagelock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idettman idettman idettman approved these changes

Assignees

@idettman idettman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teranchristian @idettman @jsnellbaker @monofonik