Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified how gdpr info is being sent from adapter #3253

Merged
merged 9 commits into from
Nov 6, 2018
Merged

Modified how gdpr info is being sent from adapter #3253

merged 9 commits into from
Nov 6, 2018

Conversation

bjorn-lw
Copy link
Contributor

@bjorn-lw bjorn-lw commented Nov 2, 2018

Type of change

  • Other: Modified how GDPR info is being passed from the adapter.

Description of change

Previously, no CMP being used on the site and gdprApplies = false were both sending in gdprApplies = false into the endpoint. Now differentiate between the two cases.

Also, modified the endpoint from forcing https to using // protocol.

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit ec47ed0 into prebid:master Nov 6, 2018
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
* Livewrapped bid and analytics adapter

* Fixed some tests for browser compatibility

* Fixed some tests for browser compatibility

* Changed analytics adapter code name

* Fix double quote in debug message

* modified how gdpr is being passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants