appnexus adapter support empty keyvalues in bidder params #3257
Conversation
modules/appnexusBidAdapter.js
Outdated
| @@ -178,6 +178,14 @@ export const spec = { | |||
| params.use_pmt_rule = (typeof params.usePaymentRule === 'boolean') ? params.usePaymentRule : false; | |||
| if (params.usePaymentRule) { delete params.usePaymentRule; } | |||
|
|
|||
| if (utils.isArray(params.keywords) && params.keywords.length > 0) { | |||
| params.keywords.forEach(function(keyPairObj) { | |||
| if (utils.isArray(keyPairObj.value) && keyPairObj.value.length > 0 && keyPairObj.value[0] === '') { | |||
There was a problem hiding this comment.
The if statement here and on line 360 are same. Please move in some function.
| @@ -261,6 +261,8 @@ describe('AppNexusAdapter', function () { | |||
| singleArrNum: [5], | |||
| multiValMixed: ['value1', 2, 'value3'], | |||
| singleValNum: 123, | |||
| emptyStr: '', | |||
There was a problem hiding this comment.
I am not sure if this is valid use case but what will happen if someone adds emptyStr: ' ' (space is added as value).
There was a problem hiding this comment.
the space character is treated as the value for the key-pair and is preserved in the ut request.
eg "keywords":[{"key":"color","value":["red"]},{"key":"mytest"},{"key":"myspacetest","value":[" "]}]
There was a problem hiding this comment.
As a follow-up to the above, the treatment of the space character has not been changed through this PR. Using a space character as a keyvalue in master would result in the same type of object for the ut request as noted above.
| return !!(utils.isArray(arr) && arr.length > 0); | ||
| } | ||
|
|
||
| function deleteValues(keyPairObj) { |
There was a problem hiding this comment.
nit; please rename to deleteEmptyValues or similar.
* appnexus adapter support empty keyvalues in bidder params * create function to check if array is populated * refactor forEach functions
Type of change
Description of change
This change allows the appenxus bidder param
keywordsto accept an empty keyvalue and subsequently pass just thekeyparam to the adserver.In terms of setup, the bidder param would just use an empty string as the value; examples below:
or
Based on the above, the
tags[...].keywordsobject in the ut request would look like the following:A similar structure would be used in the request to PBS for the
imp[...].ext.appnexus.keywordsobject.