Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarsMedia analytic adapater to use PREBID_GLOBAL than hard-coded pbjs #3261

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

pm-harshad-mane
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

MarsMedia analytic adapter to use PREBID_GLOBAL than hard-coded pbjs.
The adapter may not work if somebody sets namespace other than "pbjs"

@pm-harshad-mane
Copy link
Contributor Author

Hello @jsnellbaker , @
Can you please check this PR?

@jsnellbaker jsnellbaker self-requested a review November 5, 2018 16:23
@jsnellbaker jsnellbaker self-assigned this Nov 5, 2018
@jsnellbaker jsnellbaker merged commit db24dea into prebid:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants