Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXBidAdapter: add support for platform ids #3282

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

rjvelicaria
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other
    additional param to support a feature in openxBidAdapter

Description of change

Users can now use either a delivery domain or a platform id provided by their OpenX representative.

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@rjvelicaria
Copy link
Contributor Author

CircleCI is posting a failed test on CMP workflow for some reason. I'm not sure how that is related to my changes.

@jsnellbaker
Copy link
Collaborator

@rjvelicaria Can you re-base off of master to try to clear the circleci errors? There were a few semi-recent updates we made in the test directory and a few test files to help clear these sporadic errors. So if you update your local copy, it should clear them.

@jsnellbaker jsnellbaker self-requested a review November 12, 2018 15:01
@jsnellbaker jsnellbaker self-assigned this Nov 12, 2018
@jsnellbaker
Copy link
Collaborator

@rjvelicaria These changes look fine. Can you put together a docs-PR (at here) to update the bidder params?

The changes you made in this repo's .md won't transition to the prebid.org site, so a separate PR for the docs repo is needed.

We should be good to merge once that's made. Thanks.

@rjvelicaria
Copy link
Contributor Author

@jsnellbaker thanks for the help!
prebid/prebid.github.io#1033

@jsnellbaker
Copy link
Collaborator

Thanks for making the docs-PR. I ran the browserstack tests locally and everything passed.

@jsnellbaker jsnellbaker merged commit 40c8284 into prebid:master Nov 13, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants