Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Optimera scores file base path. #3312

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

mcallari
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • [x ] Other

Description of change

We are changing the S3 bucket location, so we are updating the base path in the adaptor. We are still writing to the previous bucket for backward compatibility.

@mcallari
Copy link
Contributor Author

HI @mkendall07 and @jsnellbaker, I see the browserstack test failed, but I can't reproduce this locally. Is this an issue on the CI side?

Thanks,
Mike

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the previous run of the browserstack had some intermittent problem for IE. I reran the build in circleCI and it passed successfully.

LGTM

@jsnellbaker jsnellbaker merged commit 45a41ad into prebid:master Nov 28, 2018
loic-talon pushed a commit to onfocusio/Prebid.js that referenced this pull request Dec 19, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants